{RETIRED} XWiki Blog Application

Create new post form triggers a JS error in IE6/IE7

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.6
  • Fix Version/s: 1.7
  • Component/s: Scripts and Style
  • Labels:
    None
  • Similar issues:
    XABLOG-118Make "Create a new post" form compliant with our inline forms standard
    XABLOG-96Add the Create a new post to category pages - when used by default select that category
    XABLOG-66Internet Explorer 6,7 and 8 don't publish blog posts with the correct date
    XABLOG-75Remove title duplication in Blog post
    XABLOG-15Create page for viewing all unpublished posts
    XABLOG-120New Blog share same articles as XWiki main blog
    XABLOG-28Clicking on "hide this article" triggers the loading icon but the page isn't updated in IE6
    XABLOG-50Create new blog articles in XWiki 2.0 syntax
    XABLOG-12Add a Recent Posts Panel
    XABLOG-64Adding an empty category returns a "This document already exists" message

Description

We need to comment/delete the following code in Blog.BlogScripts JS extension:

/*
Event.observe(form, "submit", function() {
form.action="$

{xwiki.getURL('__space__.__name__', 'inline')}

".replace(/_space/, encodeURIComponent(form.entrySpace.value)).replace(/name_/, encodeURIComponent(form.entryTitle.value));
});
*/

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ludovic Dubost added a comment -

For review

Show
Ludovic Dubost added a comment - For review
Hide
Permalink
Sergiu Dumitriu added a comment -

Fixed in rev. 21972

The onsubmit listener was supposed to save a HTTP request + redirect, since JavaScript can compute the correct target location. However, this means duplicating the velocity code in CreatePost, and any code duplication is a source of bugs, as this issue proves. I removed this JS behavior since an extra request is better than code duplication (especially in a different programming language).

Show
Sergiu Dumitriu added a comment - Fixed in rev. 21972 The onsubmit listener was supposed to save a HTTP request + redirect, since JavaScript can compute the correct target location. However, this means duplicating the velocity code in CreatePost, and any code duplication is a source of bugs, as this issue proves. I removed this JS behavior since an extra request is better than code duplication (especially in a different programming language).

People

  • Assignee:
    Sergiu Dumitriu
    Reporter:
    Ludovic Dubost
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
    Date of First Response: