Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.2 RC1
    • Fix Version/s: 2.0 M1
    • Component/s: XEclipse
    • Labels:
      None
    • Environment:
      XWiki Eclipse 1.2 RC1, XWiki Enterprise 2.0.2, MySQL 5.1.40, Tomcat 6.0.20, Java 1.6.0, Debian GNU/Linux 5.0
    • keywords:
      patch
    • Similar issues:

      Description

      1. Start XEclipse.

      2. Create a new page in the sandbox:

      File
      -> New page
      -> Space: Sandbox
      -> Name: loremipsum
      -> Title: Lorem Ipsum
      -> Finish
      

      3. Copy the contents of loremipsum.txt and paste it with CTRL+V into the new page.

      4. XEclipse is blocked for 154 seconds.

      5. Save the new page with CTRL+S.

      6. XEclipse is blocked for 160 seconds.

      1. Improvement_XECLIPSE-144.txt
        13 kB
        Venkatesh Nandakumar
      2. loremipsum.txt
        15 kB
        Clemens Fuchslocher
      3. XECLIPSE-144-20091128-1.patch
        14 kB
        Clemens Fuchslocher
      4. XECLIPSE-144-20091128-2.patch
        14 kB
        Clemens Fuchslocher
      5. XECLIPSE-144-20091128-3.patch
        15 kB
        Clemens Fuchslocher
      6. XECLIPSE-144-20091129-1.patch
        16 kB
        Clemens Fuchslocher

        Issue Links

          Activity

          Hide
          Fabio Mancinelli added a comment -

          Applied patch. Thanks Clemens (and I apologize for the huge delay)

          Fixed at https://github.com/xwiki/xwiki-eclipse/commit/8952bb5a74a7690d9df109ed1720635f4c8e4e42

          Show
          Fabio Mancinelli added a comment - Applied patch. Thanks Clemens (and I apologize for the huge delay) Fixed at https://github.com/xwiki/xwiki-eclipse/commit/8952bb5a74a7690d9df109ed1720635f4c8e4e42
          Hide
          Vincent Massol added a comment -

          Venkatesh, are you still active on this (it's marked in progress)?

          Show
          Vincent Massol added a comment - Venkatesh, are you still active on this (it's marked in progress)?
          Hide
          Clemens Fuchslocher added a comment -
          Show
          Clemens Fuchslocher added a comment - Please see XECLIPSE-144-20091129-1.patch .
          Hide
          Sergiu Dumitriu added a comment -

          Yes, sounds good. Could you prepare a final patch?

          Show
          Sergiu Dumitriu added a comment - Yes, sounds good. Could you prepare a final patch?
          Hide
          Clemens Fuchslocher added a comment -

          I can reimplement DefinitionListRule like this:

          public class DefinitionListRule extends ListRule
          {
              public DefinitionListRule(String regex, IToken token)
              {
                  super(regex, token);
              }
          
              @Override
              public IToken evaluate(ICharacterScanner scanner)
              {
                  IToken token = super.evaluate(scanner);
                  // Is there a definition list?
                  if (token == Token.UNDEFINED) {
                      // No.
                      return token;
                  }
          
                  // Yes. Consume the rest of the line.
                  readLine(scanner);
                  return token;
              }
          }
          
          • Semantic benefit: DefinitionListRule is a ListRule.
          • Technical benefit: DefinitionListRule reuses the evaluate method of ListRule without any code duplication.
          Show
          Clemens Fuchslocher added a comment - I can reimplement DefinitionListRule like this: public class DefinitionListRule extends ListRule { public DefinitionListRule(String regex, IToken token) { super(regex, token); } @Override public IToken evaluate(ICharacterScanner scanner) { IToken token = super.evaluate(scanner); // Is there a definition list? if (token == Token.UNDEFINED) { // No. return token; } // Yes. Consume the rest of the line. readLine(scanner); return token; } } Semantic benefit: DefinitionListRule is a ListRule. Technical benefit: DefinitionListRule reuses the evaluate method of ListRule without any code duplication.

            People

            • Assignee:
              Fabio Mancinelli
              Reporter:
              Clemens Fuchslocher
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: