Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-14892

Revisions are not displayed in the URL anymore when comparing history versions

    XMLWordPrintable

Details

    • Easy
    • N/A
    • N/A
    • Pull Request accepted

    Description

      Problem: Currently when we are viewing history changes, the version range is display only in the UI, but is not available in the URL.
      Being able to see the revision range in the URL would:

      • help users give permalinks of the changes;
      • manually change the range without the need to select it from the livetable. This would also help with XWIKI-6681

      Solution:
      Change the form#historyform method from post to get.

      Current: 

      http://...Page/?viewer=changes

      Expected: 

      http://...Page/?viewer=changes&rev1=1.1&rev2=2.1

      Issues:
      After the change, the URL will transform into

      http://...Page/?viewer=changes&form_token=b9knmchO5QFydZ0EmZ17PA&language=en&rev2=2.1&rev1=1.1

      Since there is no need for CSRF prevention in this case, we could remove the form_token in order to simplify the URL.

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-15744 Refactor historyinline.vm to rely less on JS for its behaviour

          • Major - Major loss of function.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-15883 Selected page versions range cannot be deleted anymore from History tab

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-6681 Unable to compare document version displayed on different page of the history version livetable

          • Major - Major loss of function.
          • Open

          Activity

            People

              surli Simon Urli
              evalica Ecaterina Moraru (Valica)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: