XWiki Platform
  1. XWiki Platform
  2. XWIKI-1701

Compress Javascript files to reduce download times

    Details

    • Development Priority:
      Medium
    • Similar issues:

      Issue Links

        Activity

        Hide
        Vincent Massol added a comment -

        it should be package phase (and not release phase). I agree with jerome for a profile.

        Show
        Vincent Massol added a comment - it should be package phase (and not release phase). I agree with jerome for a profile.
        Hide
        Jerome Velociter added a comment -

        This will make skinning XWiki a lot more complicated than it is already... If we do that I think we need to package both the minified and the regular .css files, configure the wiki to use the minified version by default in XWikiPreferences, and document in the skinning section how to use/see the non-minified one, wdyt ?

        Show
        Jerome Velociter added a comment - This will make skinning XWiki a lot more complicated than it is already... If we do that I think we need to package both the minified and the regular .css files, configure the wiki to use the minified version by default in XWikiPreferences, and document in the skinning section how to use/see the non-minified one, wdyt ?
        Hide
        Jean-Vincent Drean added a comment - - edited

        This will make skinning XWiki a lot more complicated than it is already...

        This is the kind of lines we'll get after minification:

        .grid{margin:2px 0 5px;border-collapse:collapse;width:90%;}
        .grid th{border-right:#ccc 1px solid;padding-right:4px;border-top:#ccc 1px solid;padding-left:4px;back
        ground:#f0f0f0;padding-bottom:2px;border-left:#ccc 1px solid;padding-top:2px;border-bottom:#ccc 1px so
        lid;text-align:center;font-family:Verdana,Arial,Helvetica,sans-serif;font-size:11px;}
        

        I'm note sure that it makes XWiki skinning more difficult, it makes the raw css more difficult to read but the use of firebug is already mandatory to make a skin for XWiki, so...

        Show
        Jean-Vincent Drean added a comment - - edited This will make skinning XWiki a lot more complicated than it is already... This is the kind of lines we'll get after minification: .grid{margin:2px 0 5px;border-collapse:collapse;width:90%;} .grid th{border-right:#ccc 1px solid;padding-right:4px;border-top:#ccc 1px solid;padding-left:4px;back ground:#f0f0f0;padding-bottom:2px;border-left:#ccc 1px solid;padding-top:2px;border-bottom:#ccc 1px so lid;text-align:center;font-family:Verdana,Arial,Helvetica,sans-serif;font-size:11px;} I'm note sure that it makes XWiki skinning more difficult, it makes the raw css more difficult to read but the use of firebug is already mandatory to make a skin for XWiki, so...
        Hide
        Jerome Velociter added a comment -

        from http://platform.xwiki.org/xwiki/bin/view/AdminGuide/Skins, section Modifying a Skin

        "To start, the best is to copy-paste the original content and make a slight modification."

        It will still make editing more difficult when modifying/overriding an existing skin

        Show
        Jerome Velociter added a comment - from http://platform.xwiki.org/xwiki/bin/view/AdminGuide/Skins , section Modifying a Skin "To start, the best is to copy-paste the original content and make a slight modification." It will still make editing more difficult when modifying/overriding an existing skin
        Hide
        Jean-Vincent Drean added a comment -

        Commited. You can use the debug profile to avoid JS/CSS compression.

        Show
        Jean-Vincent Drean added a comment - Commited. You can use the debug profile to avoid JS/CSS compression.

          People

          • Assignee:
            Jean-Vincent Drean
            Reporter:
            Vincent Massol
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Date of First Response: