XWiki Platform

Insert link to wiki page, web page, email

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.7 M1
  • Fix Version/s: 1.7 RC1
  • Component/s: WYSIWYG Editor
  • Labels:
    None
  • Environment:
    any
  • keywords:
    link wiki wysiwyg dialog
  • Similar issues:
    XWIKI-3641Creating a link to an existing Wiki page / external site
    XWIKI-3116A link to an email address is displayed differently than a link to a web page
    XWIKI-415WYSIWYG Editor Link Popup searching for wiki pages
    XWIKI-7362Cannot insert a link when the rich text area is empty
    XWIKI-414WYSIWYG Editor Link Popup renaming
    XWIKI-877Web urls that point to the host XWiki is running on replaced with non-working links
    XWIKI-3599Cannot create a hyperlink to another page on the Wiki using Link > Wiki page.
    XWIKI-3712Create an improved Image & Attachment Insertion UI
    XWIKI-4309Links fail to open in a new window
    XWIKI-835Links to web and blog rss feeds should not be rendered on login page if not visible by XWikiGuest

Description

The user needs to be able to insert a link to an existing wiki page, to a new wiki page, to a web page or to an email address.
Regarding this Guillaume has propose the following design: http://dev.xwiki.org/xwiki/bin/view/Design/NewWysiwygEditorInterface.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. XWIKI-2856 Allow to unset the link mode when clicking the unlink button at one end of the link text.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.

Task - A task that needs to be done. XWIKI-2829 Don't allow adding links around block elements

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.
relates to

Task - A task that needs to be done. XWIKI-3266 Allow editing inserted links

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. XWIKI-2906 Tooltips for buttons from insert link dialog

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Marcela Mihai made changes -
Field Original Value New Value
Assignee Marcela Mihai [ marcela.mihai ]
Hide
Permalink
Marcela Mihai added a comment -

I attached the patch containing the implementation for insert link feature.
Anca will add the new implementation for the unlink command and enabling/disabling the buttons from the toolbar.

Show
Marcela Mihai added a comment - I attached the patch containing the implementation for insert link feature. Anca will add the new implementation for the unlink command and enabling/disabling the buttons from the toolbar.
Marcela Mihai made changes -
Attachment XWIKI-2781.patch [ 13743 ]
Anca Luca made changes -
Link This issue is related to XWIKI-2829 [ XWIKI-2829 ]
Anca Luca made changes -
Link This issue is related to XWIKI-2856 [ XWIKI-2856 ]
Hide
Permalink
Anca Luca added a comment -

A few general and short comments about the patch (the submitted one and also the intermediary versions of it that I've seen and commented):

  • a few notes on the architecture approach:
  • weak usage of a controller to transform view calls (UI calls) into server aync calls - which led to specific, non-reusable serverside code written to serve the particular purpose of a specific ui action
  • too much duplicate code (the initial service implementation (not present in this patch), the links tabs)
  • useless storage of data in member variables, especially as this happened in the context of the client code
  • strange approach for a couple of problems (e.g. filling the dropdown boxes on selection change), messed up responsibilities (e.g. LinkDialog responsible for initialization and update of its child tabs)
  • as a general impression, not enough overall view, local analysis of situations instead of a contextual approach and integration with the rest.
  • otherwise good, clean, non-hacky approach. Easy to understand the general idea and relatively easy to work on top of it. Also, working, tested code.
  • codestyle, procedures:
  • good, strict follow of formatting rules
  • awareness and follow of checkstyle rules, but missing or useless comments someplaces.
  • no comments whatsoever in code, which should be there to help understand the logic or necessity of some parts

It would be good to see more agile-style approach of problems: incremental development, starting with minimal functionalities / code, then iterating and adding more and more, with review of the whole landscape and potential refactor at each iteration.

Show
Anca Luca added a comment - A few general and short comments about the patch (the submitted one and also the intermediary versions of it that I've seen and commented): a few notes on the architecture approach: weak usage of a controller to transform view calls (UI calls) into server aync calls - which led to specific, non-reusable serverside code written to serve the particular purpose of a specific ui action too much duplicate code (the initial service implementation (not present in this patch), the links tabs) useless storage of data in member variables, especially as this happened in the context of the client code strange approach for a couple of problems (e.g. filling the dropdown boxes on selection change), messed up responsibilities (e.g. LinkDialog responsible for initialization and update of its child tabs) as a general impression, not enough overall view, local analysis of situations instead of a contextual approach and integration with the rest. otherwise good, clean, non-hacky approach. Easy to understand the general idea and relatively easy to work on top of it. Also, working, tested code. codestyle, procedures: good, strict follow of formatting rules awareness and follow of checkstyle rules, but missing or useless comments someplaces. no comments whatsoever in code, which should be there to help understand the logic or necessity of some parts It would be good to see more agile-style approach of problems: incremental development, starting with minimal functionalities / code, then iterating and adding more and more, with review of the whole landscape and potential refactor at each iteration.
Hide
Permalink
Anca Luca added a comment -

Closed issue after fixing the subtasks and written the review for Marcela's patch.

Show
Anca Luca added a comment - Closed issue after fixing the subtasks and written the review for Marcela's patch.
Anca Luca made changes -
Status Open [ 1 ] Closed [ 6 ]
Fix Version/s 1.7 RC1 [ 10835 ]
Resolution Fixed [ 1 ]
Marcela Mihai made changes -
Link This issue relates to XWIKI-2906 [ XWIKI-2906 ]
Anca Luca made changes -
Link This issue relates to XWIKI-3266 [ XWIKI-3266 ]

People

  • Assignee:
    Marcela Mihai
    Reporter:
    Marcela Mihai
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
    Date of First Response: