Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.4.3
-
Component/s: {Unused} Rendering 2.0
-
Labels:None
-
Tests:Unit
-
Difficulty:Medium
-
Similar issues:
Description
In certain cases some styles will be lost in HTML to Syntax 2.0 conversion
This content
<html> <body> <font style="color: #ff0000"><span lang="fr-FR"><b>Hello</b></span></font> <span style="color: #ff0000"><span lang="fr-FR"><b>Hello</b></span></span> <span style="color: #ff0000"><b>Hello</b></span> </body> </html>
Converts to:
(% lang="fr-FR" %)**Hello**(%%) (% lang="fr-FR" %)**Hello**(%%) (% style="color: #ff0000" %)**Hello**
The first 2 lines don't keep the color style while the last one does.
This is particularly problematic because the first line is an example coming from an OpenOffice conversion
Issue Links
- is duplicated by
-
XWIKI-3234
Error while parsing nested <span> elements with styles
-
Activity
According to http://validator.w3.org font is not valid xhtml element.
Let's forget the font element for now as I think we have a pretreatment in the office import module.
But look at the second line
<span style="color: #ff0000"><span lang="fr-FR"><b>Hello</b></span></span>
Only the "lang" param stays in the end: (% lang="fr-FR" %)*Hello*(%%)
This does not sound normal to me.
Here is the exact content that I managed to get out of the office importer module:
<p class="western" style="margin-bottom: 0cm">This is a test with <span style="color:#ff0000;"><span lang="en-US">red</span></span> in two <span style="color:#ff0000;">different</span> ways.</p>
This does not sound normal to me.
I never said it was normal, i would have closed this issue. I only commented the font part.
Done. Note that i did not do anything for font element.
This seems to still fail in this example:
<span style="color:#ff0000;"><span style="font-family:Arial, sans-serif;"><span style="font-size:1.0em;"><span lang="fr-FR">test</span></span></span></span>
Result is:
(% style="font-size:1.0em;" lang="fr-FR" %)test
Seems like only the first two levels are used here
No it's because there is two style attribute to merge, i will take care of this.
It has nothing to do with color, pretty sure the parser simply does not take into account font element or something.