XWiki Platform

Include macro with context=current should resolve reference based on current document instead of source document

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.2
  • Fix Version/s: 3.4-milestone-1, 3.3.1, 3.2.1
  • Component/s: Rendering
  • Labels:
    None
  • Tests:
    Unit
  • Difficulty:
    Unknown
  • Similar issues:
    XWIKI-8824Recursing check in include macro is broken for context=current
    XWIKI-5148viewrev should be associated to the document reference instead of the context
    XWIKI-5807Add support for relative links/images in included documents
    XWIKI-8832Include macro does not resolve its reference properly cross wiki (when page is displayed with display macro)
    XWIKI-4929XWikiDocument#getParent and setParent does not serialize/resolve the reference based on the document but on the current context
    XWIKI-8685Chart macro should use current document as reference when resolving "document" parameter.
    XWIKI-7301References are resolved relative to the applied sheet
    XWIKI-5020syntax2.0 include macro has trouble when context=new and included document is syntax1.0 with velocity code.
    XWIKI-8308Context Macro may resolve incorrectly a relative document reference passed to it as parameter
    XWIKI-9190Document reference is not properly resolved in the new security system bridge (XWikiCachingRightService)

Description

We changed this behavior during 3.0 but we now think it's better to resolve on the current document by default.

See http://markmail.org/message/dl3jz5g7iulumw43

Issue Links

blocks

Bug - A problem which impairs or prevents the functions of the product. XWIKI-7301 References are resolved relative to the applied sheet

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.
depends on

Improvement - An improvement or enhancement to an existing feature or task. XRENDERING-171 Introducing new metadata in to indicate the base reference to use to resolve references

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. XWIKI-7516 Documents included using the reference parameter of the include macro don't appear in the list of included pages

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Thomas Mortagne made changes -
Field Original Value New Value
Link This issue depends on XRENDERING-171 [ XRENDERING-171 ]
Thomas Mortagne made changes -
Assignee Thomas Mortagne [ tmortagne ]
Thomas Mortagne made changes -
Status Open [ 1 ] Closed [ 6 ]
Tests Unit [ 10002 ]
Fix Version/s 3.2.1 [ 12556 ]
Fix Version/s 3.4-milestone-1 [ 12760 ]
Fix Version/s 3.3.1 [ 12841 ]
Resolution Fixed [ 1 ]
Marius Dumitru Florea made changes -
Link This issue relates to XWIKI-7516 [ XWIKI-7516 ]
Marius Dumitru Florea made changes -
Link This issue blocks XWIKI-7301 [ XWIKI-7301 ]

People

  • Assignee:
    Thomas Mortagne
    Reporter:
    Thomas Mortagne
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: