Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-8929

Remove ugly HTML-escape hack in AttachmentDiff#toString

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 5.0-milestone-2
    • 5.0-milestone-1
    • Old Core
    • None
    • Unit
    • Unknown
    • N/A
    • N/A

    Description

      toString() methods should not be used as displayers. They shouldn't be substitutes for displayers. They should be used for printing logs/exceptions.

      FTR this code is used to display attachment diff in the diff UI and in the watchlist HTML email.

      Added in rev 62368e9423925fbd496a5cc057a076b37b62f9ee with message "[misc] Improve javadoc, add AttachmentDiff.toString()"

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-8928 Watchlist HTML email is displaying "null" when a new attachment is added

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-8932 Improve the way changes are displayed in Watchlist notification emails

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              sdumitriu Sergiu Dumitriu
              vmassol Vincent Massol
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: