Some review comments (We discussed some of them on IRC but I'm noting them here for the record):

• You should fix the tests so that they are real tests, i.e. they must verify the output of the conversion.
• We shouldn't use JDOM for the filtering. Since 2.0 htmlcleaner has some nice and efficient methods for filtering the cleaned HTML.
• We should move the HTML cleaning code in the rendering-api module and add tons of tests for it. (I can help)
• HTML to wiki conversion should work - This is the biggest limitation right now since it's not started and is the hard part of the project
• Some code should be componentized (I can help)

Thanks
-Vincent

• Code needs to use xwiki-xml/ HTMLCleaner
• OfficeConverter.java should have only one method that outputs a stream. Client code can do the conversion to other formats (string, array of bytes, etc).
• Missing Javadoc (for example for OfficeConverter.java)
• Missing @version and @since tags
• XWiki coding style not applied to some files (for example to pom.xml - it's using 4 spaces instead of 2; same for the office converter excpetion class which has braces at the end of a line for a method)
• There should be no @author tags
• Sentences should start with uppercase letter (in javadocs).
• Unused code. For example:

	public static final String DEFAULTCONVERTERTYPE = "localhost";
	public static final String SERVICECONVERTERTYPE = "service";

Actually the office converter factory should be removed altogether since it's not used.

• Use a component for OfficeConverter/DefaultOfficeConverter
• Needs better error messages. Need to use "[" and "]" in error messages when displaying values. Best practice is actually to use String.format().
• AbstractOfficeConverter not required since there's now only 1 method in OfficeConverter
• TODO leftover like:

        // TODO automatically start the open office server
        // soffice -headless -accept="socket,host=127.0.0.1,port=8100;urp;" -nofirststartwizard

• Provide configuration parameter in components.xml for DefaultOfficeConverter component for server name/IP + port
• OfficeServerConnection class is not required and the code for connecting to the office server should be moved to DefaultOfficeConverter, in it's initialize() method (it should implement Initializable).
• Util JDOM to string should be removed and you should use XMLUtils.toString() instead where required.
• Util should be removed in general and methods moved elsewhere.
• There should be an output type for wiki syntax. We need to design this so that it's independent of the wiki syntax use and uses the rendering system for that.
• I'll review the plugin later on when these issues have been fixed.

Thanks!