[#XWIKI-114] Adding comment for edit changes

XWiki Core

Adding comment for edit changes

Created: 15/Jul/05 23:13 Updated: 19/Jun/08 15:02

Component/s:

Wiki features

Affects Version/s:

1.0 B4

Fix Version/s:

1.1 M1

File Attachments:

comment2.patch (39 kB)

Issue Links:

Duplicate

This issue is duplicated by:

~~XWIKI-687~~ Version summary

Related

This issue is related to:

~~XWIKI-2487~~ Hiding the edit comment field doesn't work

keywords:	curriki
Date of First Response:	10/Apr/07 11:22
Resolution Date:	08/May/07 20:44

Description

« Hide

It should be possible to add a comment for each update of a Wiki page.

All

Comments

Change History

FishEye

Sort Order:

[ Permlink | « Hide ]

Ludovic Dubost added a comment - 13/Feb/07 16:38

Vincent, we need to move this feature back to 1.0, since we need this feature for Curriki. Could it be possible to prioritize it for the end of the month of February.

[ Permlink | « Hide ]

Ludovic Dubost added a comment - 22/Mar/07 21:54

Vincent, can we higher the priority of this task

[ Permlink | « Hide ]

Vincent Massol added a comment - 10/Apr/07 11:22

Ludovic, I won't have the time to implement this one for the RC1 release (which is meant to become the 1.0 release). I'm proposing to move this to 1.1 Beta 1 as it's a new feature.

[ Permlink | « Hide ]

Ludovic Dubost added a comment - 08/May/07 11:42

I'm proposing the following behavior:

1. Use edit comments
  xwiki.editcomment=1
2. Hide editcomment field and only use JS
  xwiki.editcomment.hidden=0
3. Make edit comment mandatory
  xwiki.editcomment.mandatory=1

If xwiki.editcomment is 1 then a field edit comment is included and a JS is added to propose to fill in the field if it's empty.
If xwiki.editcomment.hidden is 1 then the edit comment field is not shown (and only the JS is used)
If xwiki.editcomment.mandatory is 1 then the JS will not get out until the field is filled

In terms of implementation it is adding a "comment" field in the XWikiDocument object

[ Permlink | « Hide ]

Ludovic Dubost added a comment - 08/May/07 13:34

Patch for comment field implementation

[ Permlink | « Hide ]

Ludovic Dubost added a comment - 08/May/07 13:35

Vincent,

Can you review the patch attached.. I need to commit it ASAP

[ Permlink | « Hide ]

Ludovic Dubost added a comment - 08/May/07 16:04

New patch for comment feature

[ Permlink | « Hide ]

Ludovic Dubost added a comment - 08/May/07 20:44

Fixed in svn r3130 r3131 after review of Sergiu