|
[
Permlink
| « Hide
]
Artem Melentev added a comment - 03/Jul/07 18:45
Minor versions will be named like 1.2.3 (major - 1.2)
First preview version patches attached
Minor versions will increase 2nd version number. Major - 1st. (ex: 1.1-minor-1.2-major- 2.1-minor- 2.2)
added show/hide minor edits in history view.
Adding objects,attachments,comments,rights to document is minor changes.
The problem is "what's new" page in XE. How to find latest major change of document? Maybe we need doc.majorEditDate() and doc.latestMajorAuthor()
Since minorEdit must be in the hibernate mapping, then you can check it in the query, "... and doc.minorEdit = 0 ..."
2Sergiu:
By the current versioning store, only last version of document is stored in DB (and archive is stored in document), so if somebody do major edit and next minor edit, we skip this document with hsql "... and doc.minorEdit = 0 ..." (I think it is wrong, because major edit was done  )
To make it work I need to implement "keep document history in a separate table" before this task. hql query for major only what's new:
select distinct doc.web, doc.name from XWikiDocument as doc, XWikiRCSNodeInfo as ni where doc.id=ni.id.docId and ni.id.version2=1 group by doc.web, doc.name order by max(ni.date) desc (versions like x.1 is major edits) Attached
Main.Dashboard show documents order by major change date by default. Artem I guess this means the idea is that these changes don't appear in the What's New either is that right?
Also how will I be able to see all changes? The reason I ask this is that I'm watching over xwiki.org every day and I need to know if someone has made a change, and adding a new object to a page happens frequently is a major change that I need to revert (like when a user adds a new right to a page). What will be the process I can use now to ensure I see all changes easily? Thanks Vincent, I modified only Main.Dashboard in
Main.Dashboard has a switch show/hide minor edits. By default only major edits is shown. Maybe we need to save user preference about show or hide minor edits in user's profile. WDYT?
I think what you've done so far is good. Let's keep it simple for now and see how it goes. I'll let you know how it goes after I use it for real on xwiki.org and we can always devise ways of improving visibility for those who require it. Thanks Artem,
Just tested minor edits and it's not working for me. I simply ran the full build and installed the XE standalone version. Here's what I did:
I could see my change in the list and when I clicked on "show minor edits" it showed a bunch of other changes which were never marked as minor edits I believe. Also you need to use an uppercase "S" in "show minor edits" as in English first letter of sentences are in uppercase. Thanks reopen for now as it's not working for me)
Vincent,
xe-database module produce old database (it is use core-1.1M2), so history (xwikircs table) will be empty. If you will import xar by new core, all will be fine. This problem will be fixed if we write migration ( If XE Database is moved to core-1.1M4 will it work? If so then why don't we do this?
I mean right now, from a user point of view, this feature is NOT working, as they'll expect something that works when they download the XE standalone version. They should NOT have to run any migration tool if they install 1.1M4 standalone of course Could you fix that? -Vincent So you propose to use xwiki-core-SNAPSHOT in xe-database module? This will resolve this problem.
But this issue can't be included in 1.1M4 because it depends on |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
New Feature
Closed
Minor
Minor edit of document
