|
Patch for the core issue that creates a document with the wrong initial version.
Another patch is needed to migrate existing data and/or fix the screens/functions impacted by this issue Patch to fix the versioning issue. This patch will detect that the RCS file is not in sync with the latest document version and update the RCS file transparently.
This is not expensive and is called in the few functions where this is needed for the UI to present correct data. We can also write an update script in the wiki to fix all documents at once fixed in r4119.
Need import&export to affect. Remained issue: Latest doc version may be not sync with rcs, until next save. I think this issue is not too important for now. For this issue migration system is needed. Tell me if something wrong. my changes rollbacked.
but Ludovic's partial fix stay in the trunk, so will be in 1.1M4 Need we apply
Or move this issue to 1.2M1? Could this also be causing this bug http://jira.xwiki.org/jira/browse/XWIKI-1582
Reconstruct doc.version history from scratch (use fromXML/toXML, setversion). sample migration script for
resave api for migration is added in r4204
Main.fixrcs-r1.xwikipage - final migration script for this issue.
It need be saved as standard xwiki page (for example Main.fixrcs page) and executed by click on link. We need write about it in 1.1M4 Reliase Notes. attached fixrcs.xar - xwiki archive with Main.fixrcs-r1.xwikipage
It is easyer for user. Artem, shouldn't the fixrcs page be located in the XWiki space (our admin space)?
If you're ok with this, could you recreate a XAR? At the same time, could you rename the page from fixrcs to FixRCS? Thanks Is Fix RCS required on the standalone version or is it only required for users who upgrade from an existing version?
Some typos in the fixrcs page:
FixRCS is requred only for users who upgrade from <1.1M4.
correction: FixRCS is requred only for users who WANT to sync version in documents and its archive. ~1.1M1-1.1M3 affected this sync out.
Release notes modified accordingly on http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise11M4
Attached FixRCS.xar with fix all remarks.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
It is annoying because It's not so easy to fix. The source problem is that the version field in the XWikiDocument object and the versions in the RCS file to not match (there is 1 version difference). This is why the display in the history page does not show the last versions.
We can fix the display part but this would be acknowledging the issue in the version file. If we try to fix the source problem we might have part of the documents with the issue and part of the documents without it.
I think we need to fix the source issue and also migrate the versions inside the version file. We can detect documents that are not migrated by the fact that the last version in the RCS file does not match the version in the current XWikiDocument.