[#XWIKI-1650] Document api should clone XWikiDocument

XWiki Core

Document api should clone XWikiDocument

Created: 22/Aug/07 16:53 Updated: 27/Aug/07 19:03

Component/s:

APIs

Affects Version/s:

1.1 M4

Fix Version/s:

1.1 RC1

File Attachments:

20070823-fix-Document-api-clonning.patch (15 kB)
2.

20070827-fix-Document-api-clonning.patch (16 kB)
3.

Document.java (55 kB)
4.

Document.java (55 kB)

keywords:	Document clone patch
Date of First Response:	23/Aug/07 18:11
Resolution Date:	27/Aug/07 19:03

Description

« Hide

This problem was introduced by ~~XWIKI-1517~~. The clone should still be there to make sure that unsaved edits to Document in script are not in a cached XWikiDocument

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Ludovic Dubost added a comment - 22/Aug/07 16:57

Fixed in 4485 and 4486

[ Permlink | « Hide ]

Ludovic Dubost added a comment - 23/Aug/07 18:01

There is still issue with the cloning. The read functions should called the cloned doc once it has been cloned

[ Permlink | « Hide ]

Thomas Mortagne added a comment - 23/Aug/07 18:11

This a patch that replace clonedDoc by a boolean cloned and clean all getDoc unnecessary (performances issues) calls.

[ Permlink | « Hide ]

Thomas Mortagne added a comment - 27/Aug/07 16:52

Replace on getDoc() call by doc.

[ Permlink | « Hide ]

Sergiu Dumitriu added a comment - 27/Aug/07 19:03

Fixed in rev. 4529

Patch applied without changes.