[#XWIKI-2467] Update queries to use doc.space instead of doc.web

XWiki Core

Update queries to use doc.space instead of doc.web

Created: 14/Jun/08 02:09 Updated: 24/Jun/08 10:39

Component/s:

Core

Affects Version/s:

None

Fix Version/s:

1.5 M2

Date of First Response:	23/Jun/08 16:12
Resolution Date:	24/Jun/08 10:39

Description

« Hide

Since doc.web is deprecated, and now doc.space can be used in queries, all queries from the core and official plugins and applications should be updated.

All

Comments

Change History

FishEye

Sort Order:

[ Permlink | « Hide ]

Sergiu Dumitriu added a comment - 21/Jun/08 04:25

Done almost everywhere, except in the scheduler plugin, Watch and Curriki (which depend on 1.4).

[ Permlink | « Hide ]

Vincent Massol added a comment - 23/Jun/08 16:12

There are still lots of warnings when starting XE on the home page:

15:18:44.553 INFO   [main] org.mortbay.jetty.servlet.ServletHandler$Context.log(ServletHandler.java:1134) >16> Plexus initialized.
15:18:46.734 INFO   [main] org.mortbay.util.Container.start(Container.java:74) >11> Started WebApplicationContext[/xwiki,xwiki]
15:18:46.738 INFO   [main] org.mortbay.http.SocketListener.start(SocketListener.java:204) >11> Started SocketListener on 0.0.0.0:8080
15:18:46.738 INFO   [main] org.mortbay.util.Container.start(Container.java:74) >09> Started org.mortbay.jetty.Server@aa0a15
15:23:24.201 INFO   [P1-19] org.mortbay.util.Container.start(Container.java:74) >08> Started HttpContext[/,/]
2008-06-23 15:23:28,739 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (get). Use doc.space instead. 
2008-06-23 15:23:28,740 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (set). Use doc.space instead. 
2008-06-23 15:23:28,750 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (get). Use doc.space instead. 
2008-06-23 15:23:28,750 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (set). Use doc.space instead. 
2008-06-23 15:23:29,384 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - Current storage version = [0] 
2008-06-23 15:23:29,384 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - List of migrations that will be executed: 
2008-06-23 15:23:29,385 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  -   R4340XWIKI883 - See http://jira.xwiki.org/jira/browse/XWIKI-883 
2008-06-23 15:23:29,385 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  -   R4359XWIKI1459 - See http://jira.xwiki.org/jira/browse/XWIKI-1459 
2008-06-23 15:23:29,385 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  -   R7345XWIKI2079 - See http://jira.xwiki.org/jira/browse/XWIKI-2079 
2008-06-23 15:23:29,386 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - Running migration [R4340XWIKI883] with version [4340] 
2008-06-23 15:23:29,564 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - New storage version is now [4341] 
2008-06-23 15:23:29,564 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - Running migration [R4359XWIKI1459] with version [4359] 
2008-06-23 15:23:29,568 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - New storage version is now [4360] 
2008-06-23 15:23:29,568 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - Skipping unneeded migration [R6079XWIKI1878] with version [6079] 
2008-06-23 15:23:29,569 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - New storage version is now [6080] 
2008-06-23 15:23:29,569 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - Skipping unneeded migration [R6405XWIKI1933] with version [6405] 
2008-06-23 15:23:29,570 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - New storage version is now [6406] 
2008-06-23 15:23:29,570 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - Running migration [R7345XWIKI2079] with version [7350] 
2008-06-23 15:23:29,572 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - New storage version is now [7351] 
2008-06-23 15:23:30,134 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (get). Use doc.space instead. 
2008-06-23 15:23:30,134 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (set). Use doc.space instead. 
2008-06-23 15:23:30,142 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (get). Use doc.space instead. 
2008-06-23 15:23:30,142 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (set). Use doc.space instead.

[ Show » ]

Vincent Massol added a comment - 23/Jun/08 16:12 There are still lots of warnings when starting XE on the home page:

15:18:44.553 INFO   [main] org.mortbay.jetty.servlet.ServletHandler$Context.log(ServletHandler.java:1134) >16> Plexus initialized.
15:18:46.734 INFO   [main] org.mortbay.util.Container.start(Container.java:74) >11> Started WebApplicationContext[/xwiki,xwiki]
15:18:46.738 INFO   [main] org.mortbay.http.SocketListener.start(SocketListener.java:204) >11> Started SocketListener on 0.0.0.0:8080
15:18:46.738 INFO   [main] org.mortbay.util.Container.start(Container.java:74) >09> Started org.mortbay.jetty.Server@aa0a15
15:23:24.201 INFO   [P1-19] org.mortbay.util.Container.start(Container.java:74) >08> Started HttpContext[/,/]
2008-06-23 15:23:28,739 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (get). Use doc.space instead. 
2008-06-23 15:23:28,740 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (set). Use doc.space instead. 
2008-06-23 15:23:28,750 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (get). Use doc.space instead. 
2008-06-23 15:23:28,750 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (set). Use doc.space instead. 
2008-06-23 15:23:29,384 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - Current storage version = [0] 
2008-06-23 15:23:29,384 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - List of migrations that will be executed: 
2008-06-23 15:23:29,385 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  -   R4340XWIKI883 - See http://jira.xwiki.org/jira/browse/XWIKI-883 
2008-06-23 15:23:29,385 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  -   R4359XWIKI1459 - See http://jira.xwiki.org/jira/browse/XWIKI-1459 
2008-06-23 15:23:29,385 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  -   R7345XWIKI2079 - See http://jira.xwiki.org/jira/browse/XWIKI-2079 
2008-06-23 15:23:29,386 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - Running migration [R4340XWIKI883] with version [4340] 
2008-06-23 15:23:29,564 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - New storage version is now [4341] 
2008-06-23 15:23:29,564 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - Running migration [R4359XWIKI1459] with version [4359] 
2008-06-23 15:23:29,568 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - New storage version is now [4360] 
2008-06-23 15:23:29,568 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - Skipping unneeded migration [R6079XWIKI1878] with version [6079] 
2008-06-23 15:23:29,569 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - New storage version is now [6080] 
2008-06-23 15:23:29,569 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - Skipping unneeded migration [R6405XWIKI1933] with version [6405] 
2008-06-23 15:23:29,570 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - New storage version is now [6406] 
2008-06-23 15:23:29,570 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - Running migration [R7345XWIKI2079] with version [7350] 
2008-06-23 15:23:29,572 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] INFO  .AbstractXWikiMigrationManager  - New storage version is now [7351] 
2008-06-23 15:23:30,134 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (get). Use doc.space instead. 
2008-06-23 15:23:30,134 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (set). Use doc.space instead. 
2008-06-23 15:23:30,142 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (get). Use doc.space instead. 
2008-06-23 15:23:30,142 [http://localhost:8080/xwiki/bin/view/Main/] [P1-19] WARN  te.DocumentWebPropertyAccessor  - Deprecated usage of doc.web property in HQL query (set). Use doc.space instead.

[ Permlink | « Hide ]

Sergiu Dumitriu added a comment - 24/Jun/08 03:22

Could be the Hibernate (or CGLib) initialization? I was planning to get a stack trace to see what causes these.

[ Permlink | « Hide ]

Sergiu Dumitriu added a comment - 24/Jun/08 05:51

Yes, I checked, and it is the hibernate initialization process that makes initial calls to all the getters and setters.

[ Permlink | « Hide ]

Sergiu Dumitriu added a comment - 24/Jun/08 07:51

Hum... This is completely useless... The current code is called only on startup, to retrieve the getter/setter (once per Hibernate instance).

I tried to log calls to the getter/setter, but apparently these are not used when constructing queries. Another thing I noticed is that Hibernate still calls get/setWeb when storing/loading objects. I guess the right way to fix this is to override the query parser.

Tough luck, I guess we can remove the code for logging completely.