[#XWIKI-2967] Add ability to display an optional image and a optional title in the Box macro

XWiki Core

Add ability to display an optional image and a optional title in the Box macro

Created: 09/Dec/08 12:21 Updated: 18/Mar/09 22:04

Component/s:

Rendering 2.0

Affects Version/s:

1.7 RC1

Fix Version/s:

1.8 M2

File Attachments:

XWIKI-2967-1.patch (13 kB)
2.

XWIKI-2967-2.1.patch (2 kB)
3.

XWIKI-2967-2.patch (12 kB)

Issue Links:

Dependency

This issue blocks:

~~XWIKI-2968~~ Implement info, warning and error macros

~~XWIKI-2882~~ Implement RSS macro for new rendering

~~XWIKI-3384~~ Convert style Radeox macro

Duplicate

This issue is duplicated by:

~~XWIKI-3025~~ Create a {{messagebox}} macro

Date of First Response:	05/Jan/09 23:28
Resolution Date:	22/Jan/09 11:17
Tests:	Unit

Description

« Hide

This would allow reimplementing the #info, #warning, #error macros using the box macro + the ability to display one's avatar next to some text when we want to put comments inside a page.

All

Comments

Change History

FishEye

Sort Order:

[ Permlink | « Hide ]

Dan M added a comment - 05/Jan/09 23:28

Added an optional title which supports Wiki syntax and an optional image, as proposed on the mailing lists.

[ Permlink | « Hide ]

Thomas Mortagne added a comment - 20/Jan/09 16:56

Why xwiki-core-bridge is added to box macro dependencies ? I don't see it used anywhere.

[ Permlink | « Hide ]

Dan M added a comment - 21/Jan/09 12:38

Done, removed that. It was just a leftover.

[ Permlink | « Hide ]

Thomas Mortagne added a comment - 22/Jan/09 11:17

Applied patch from Dan Miron without any change

Thanks

[ Permlink | « Hide ]

Thomas Mortagne added a comment - 22/Jan/09 11:20

Dan could you update the documentation at http://code.xwiki.org/xwiki/bin/view/Macros/BoxMacro with the new features ?

[ Permlink | « Hide ]

Thomas Mortagne added a comment - 22/Jan/09 11:23

And also http://code.xwiki.org/xwiki/bin/view/Macros/CodeMacro20 since it's based on box macro.

[ Permlink | « Hide ]

Dan M added a comment - 02/Feb/09 13:59

Made the code macro to use both the 'box' and 'code' css stylesheets, instead of just 'code'.

[ Permlink | « Hide ]

Thomas Mortagne added a comment - 02/Feb/09 14:07

Why do you need the if (StringUtils.isEmpty(this.getCssClass())) { ? Since you are in the constructor you now the value. The loading of the macro parameters by beanutil is done on an object so after the constructor is called.

[ Permlink | « Hide ]

Thomas Mortagne added a comment - 02/Feb/09 14:21

Apply patch for Dan without the if