[#XWIKI-3101] Replace invalid xhtml <br/> elements with <div class="wikimodel-emptyline"/> in OpenOfficeHTMLCleaner

XWiki Core

Replace invalid xhtml <br/> elements with <div class="wikimodel-emptyline"/> in OpenOfficeHTMLCleaner

Created: 12/Jan/09 00:33 Updated: 19/Jan/09 11:10

Component/s:

Office Importer

Affects Version/s:

1.7.1

Fix Version/s:

1.8 M1

keywords:	line breaks
Date of First Response:	13/Jan/09 16:58
Resolution Date:	19/Jan/09 11:10

Description

« Hide

<br/> tags are not allowed in between block elements (not valid xhtml) they need to be replaced by <div class="wikimodel-emptyline"/>.

All

Comments

Change History

FishEye

Sort Order:

[ Permlink | « Hide ]

Anca Luca added a comment - 13/Jan/09 16:58

I couldn't find any reference about this in the xhtml specification.

Also, br is an xhtml inline element, so wherever an inline element is accepted a br is accepted, including near block elements (in flow containers, for example).

Since this is not correct and is setup to run in the default html cleaner, is messes up things in the Wysiwyg by replacing expected brs with divs.

Asiri?

[ Permlink | « Hide ]

Vincent Massol added a comment - 13/Jan/09 17:14

See http://learningforlife.fsu.edu/webmaster/references/xhtml/tags/text/br.cfm

It doesn't show body as a valid parent for ex

[ Permlink | « Hide ]

Vincent Massol added a comment - 13/Jan/09 17:15

Note that this issue is ONLY for BR as block elements and NOT as inline elements. If Asiri replaced the inline elements too then it's a bug and it needs to be reverted

[ Permlink | « Hide ]

Vincent Massol added a comment - 13/Jan/09 17:41

This needs to be fixed. I think that:

BR should only be cleaned by the cleaner when they're children of body since BR don't seem to accept body as parent as shown on http://learningforlife.fsu.edu/webmaster/references/xhtml/tags/text/br.cfm
BR between block elements should be handled in the XHTML parser and not in the cleaner (since the following is valid XHTML:
```
<div><p>hello</p><br/><p>world</p></div>
```