[#XWIKI-624] xpage=editclass link does not work

XWiki Core

xpage=editclass link does not work

Created: 27/Dec/06 17:41 Updated: 02/Jan/07 18:11

Component/s:

Actions and URLs

Affects Version/s:

1.0 B1

Fix Version/s:

1.0 B2

keywords:	class editor link
Date of First Response:	02/Jan/07 00:36
Resolution Date:	02/Jan/07 18:11

Description

« Hide

When using the "wizard", in ClassSheet the link to edit the class points
to: ....NewClass?xpage=editclass which is then redirected
to ....NewClass?editor=class.

The problem is that the right menu does not appear automatically when landing
in the ...editor=class page.

On the contrary it is there when using the top menu "edit>Class" which points
directly to the ...editor=class page.

All

Comments

Change History

FishEye

Sort Order:

[ Permlink | « Hide ]

Dan Murphy added a comment - 02/Jan/07 00:36

http://localhost:8080/xwiki/bin/admin/XWiki/TestClass?editor=class is incorrect via the wizard
http://localhost:8080/xwiki/bin/edit/XWiki/TestClass?editor=class is correct via the edit menu option

looks like the redirected url is incorrectly setting to .xwiki/bin/admin instead of xwiki/bin/edit

[ Permlink | « Hide ]

Vincent Massol added a comment - 02/Jan/07 10:35

Not sure why this was assigned to me. Moving it to B2 and unassigning it for now.

[ Permlink | « Hide ]

Dan Murphy added a comment - 02/Jan/07 17:43

Not sure if this is a correct fix, but if you modify the XWiki.ClassSheet from:
The first thing to do is to <a href="$doc.getURL("edit", "xpage=editclass")">Edit the Class</a> to add properties to it.
to:
The first thing to do is to <a href="$doc.getURL("edit", "editor=class")">Edit the Class</a> to add properties to it.
Then the ClassEditor appears as expected....

[ Permlink | « Hide ]

Sergiu Dumitriu added a comment - 02/Jan/07 18:08

Thanks for the comment, it helped me locate the problem.

The editclass.vm template always redirects to the "admin" mode. The proper fix is to change in skins/xwiki10b1/editclass.vm, line 2 from:

$response.sendRedirect($doc.getURL("admin", "editor=class"))

$response.sendRedirect($doc.getURL($context.action, "editor=class"))

[ Permlink | « Hide ]

Sergiu Dumitriu added a comment - 02/Jan/07 18:11

Fixed in rev. 1844