Details
-
Bug
-
Resolution: Fixed
-
Blocker
-
2.1
-
None
-
Unknown
-
N/A
-
N/A
-
Description
Steps to reproduce
- Use XWiki 11.3.4
- Install Limits App
- Change the limit to 2 users
- Try to create 3 users
We actually have a stack trace:
2019-09-18 10:40:48,763 [https://gdelhumeau-20190916-2.demo-staging.infra-staging.devxwiki.com/xwiki/bin/view/XWiki/XWikiPreferences?xpage=registerinline] ERROR .o.i.DefaultObservationManager - Failed to send event [org.xwiki.bridge.event.DocumentCreatingEvent@e8a270ab] to listener [org.xwiki.contrib.limits.internal.users.UserListener@2b1ba3c8] java.lang.NullPointerException: null at org.xwiki.contrib.limits.internal.users.UserListener.isOldDocumentActive(UserListener.java:132) at org.xwiki.contrib.limits.internal.users.UserListener.isActivatingUser(UserListener.java:114) at org.xwiki.contrib.limits.internal.users.UserListener.onEvent(UserListener.java:89) at org.xwiki.observation.internal.DefaultObservationManager.notify(DefaultObservationManager.java:309) at org.xwiki.observation.internal.DefaultObservationManager.notify(DefaultObservationManager.java:274)
Maybe because of https://github.com/xwiki/xwiki-platform/commit/e151fbc4730f76359e179b1063f06bd45f7cd2e3, we now have a new document that have an original document object, but without a user object. Since we don't test the value of the object but we directly try to get its properties, we end up with this NPE.