Uploaded image for project: 'XWiki Commons'
  1. XWiki Commons
  2. XCOMMONS-2550

mvn xar:format crashes with a NullPointerException if the xwikidoc > hidden element is missing

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • 14.3.1
    • Development Issues only
    • None
    • Unknown

    Description

      This minimal XML file does not make mvn xar:format crash.

      <xwikidoc reference="Main.EmptyAttachment">
        <hidden>true</hidden>
      </xwikidoc>

       

      The following ones, however, do:

      <xwikidoc reference="Main.EmptyAttachment"/>

      <pleasecrash reference="Main.EmptyAttachment">
        <hidden>true</hidden>
      </pleasecrash>

       

      Expected behavior: mvn xar:format does not crash with a NPE and produces a relevant error message if applicable, or adds back a <hidden> tag like it does for other tags, if applicable.

       

      Stack trace:

      {{[ERROR] Failed to execute goal org.xwiki.commons:xwiki-commons-tool-xar-plugin:14.3.1:format (default-cli) on project xxx: Failed to format file [/xxx/src/main/resources/Main/EmptyAttachment.xml]: NullPointerException -> [Help 1]
      org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.xwiki.commons:xwiki-commons-tool-xar-plugin:14.3.1:format (default-cli) on project xxx: Failed to format file [/xxx/src/main/resources/Main/EmptyAttachment.xml]
         at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:375)
         at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
         at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
         at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
         at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
         at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
         at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
         at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
         at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
         at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
         at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
         at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
         at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
         at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
         at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
         at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
         at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
         at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
         at java.lang.reflect.Method.invoke (Method.java:566)
         at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
         at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
         at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
         at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
      Caused by: org.apache.maven.plugin.MojoExecutionException: Failed to format file [/xxx/src/main/resources/Main/EmptyAttachment.xml]
         at org.xwiki.tool.xar.FormatMojo.execute (FormatMojo.java:74)
         at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
         at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:370)
         at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
         at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
         at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
         at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
         at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
         at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
         at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
         at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
         at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
         at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
         at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
         at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
         at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
         at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
         at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
         at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
         at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
         at java.lang.reflect.Method.invoke (Method.java:566)
         at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
         at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
         at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
         at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
      Caused by: java.lang.NullPointerException
         at org.xwiki.tool.xar.FormatMojo.format (FormatMojo.java:158)
         at org.xwiki.tool.xar.FormatMojo.format (FormatMojo.java:86)
         at org.xwiki.tool.xar.FormatMojo.execute (FormatMojo.java:72)
         at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
         at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:370)
         at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
         at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
         at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
         at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
         at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
         at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
         at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
         at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
         at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
         at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
         at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
         at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
         at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
         at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
         at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
         at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
         at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
         at java.lang.reflect.Method.invoke (Method.java:566)
         at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
         at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
         at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
         at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
      }}

      Attachments

        Activity

          People

            Unassigned Unassigned
            rjakse Raphaël Jakse
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: