XWiki Enterprise

AllDocs's attachment tab requires programming right to work

Details

  • Documentation:
    n/a
  • Documentation in Release Notes:
    n/a
  • Similar issues:
    XE-612Deleted Docs/Attachment tabs on AllDocs page don't work in subwikis
    XE-834Show if page has programming rights under Information tab for advanced users
    XE-539tag suggest feature does not work if Main.WebHome is not saved with programming rights.
    XE-310XWiki.Treeview needs programming rights
    XE-832Add XWiki.RequiredRightClass to XE documents that require to be saved with certain rights
    XE-346Improve AllDocs page
    XE-614Errors in UI for deleted documents & attachments
    XE-224Write selenium test to verify the behaviour of the AllDocs ajax table
    XE-930Rendering problems of Type column from Attachments section on AllDoc
    XE-82Move Orphaned Pages inside the AllDocs page as a new tab

Description

This is a problem, especially on a XEM since when local admin import the XE XAR the page will stop working.

It should be refactored to not require PR.

Issue Links

depends on

New Feature - A new feature of the product, which has yet to be developed. XWIKI-4410 Need a way to search attachments without programming permissions

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.
is duplicated by

Bug - A problem which impairs or prevents the functions of the product. XE-612 Deleted Docs/Attachment tabs on AllDocs page don't work in subwikis

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. XWIKI-4707 "All Attachments" Live Table doesn't show any attachment

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Massol added a comment -

who can work on this?

Show
Vincent Massol added a comment - who can work on this?
Hide
Permalink
CalebJamesDeLisle added a comment -

it appears that the problem is in allAttachmentResults

#set($sql = "select doc.fullName, attach from XWikiDocument as doc, XWikiAttachment as attach where attach.docId=doc.id " + $sql + " order by $order $dir")
#set($items = $xwiki.search($sql, $limit, $off))

The only solution that comes to mind is writing a method api.XWiki.searchAttachments(String wheresql, int nb, int start)

Show
CalebJamesDeLisle added a comment - it appears that the problem is in allAttachmentResults #set($sql = "select doc.fullName, attach from XWikiDocument as doc, XWikiAttachment as attach where attach.docId=doc.id " + $sql + " order by $order $dir") #set($items = $xwiki.search($sql, $limit, $off)) The only solution that comes to mind is writing a method api.XWiki.searchAttachments(String wheresql, int nb, int start)
Hide
Permalink
Vincent Massol added a comment -

yep that's why I had initially put this issue in the XWiki Platform jira project

Show
Vincent Massol added a comment - yep that's why I had initially put this issue in the XWiki Platform jira project
Hide
Permalink
CalebJamesDeLisle added a comment -

Okay, I'm writing searchAttachments(String parametrizedSqlClause, int nb, int start, List< ? > parameterValues)
next, I'll write .searchAttachments(String wheresql, int nb, int start)

Show
CalebJamesDeLisle added a comment - Okay, I'm writing searchAttachments(String parametrizedSqlClause, int nb, int start, List< ? > parameterValues) next, I'll write .searchAttachments(String wheresql, int nb, int start)
Hide
Permalink
Thomas Mortagne added a comment -

Vincent: " AllDocs's attachment tab requires programming right to work" is about XE since it has to be modified to use a new api for which we need another jira issue in the core this time

Show
Thomas Mortagne added a comment - Vincent: " AllDocs's attachment tab requires programming right to work" is about XE since it has to be modified to use a new api for which we need another jira issue in the core this time
Hide
Permalink
CalebJamesDeLisle added a comment -

This patch depends on methods added in a patch to XWIKI-4410

Show
CalebJamesDeLisle added a comment - This patch depends on methods added in a patch to XWIKI-4410
Hide
Permalink
CalebJamesDeLisle added a comment -

This patch uses api.XWiki.searchAttachments and api.XWiki.countAttachments from XWIKI-4410 I have tested it and it can be modified by a user without programming privileges. In addition, the query is now parametrized.

Show
CalebJamesDeLisle added a comment - This patch uses api.XWiki.searchAttachments and api.XWiki.countAttachments from XWIKI-4410 I have tested it and it can be modified by a user without programming privileges. In addition, the query is now parametrized.
Hide
Permalink
CalebJamesDeLisle added a comment -

Should be fixed.

Show
CalebJamesDeLisle added a comment - Should be fixed.

People

  • Assignee:
    CalebJamesDeLisle
    Reporter:
    Vincent Massol
Vote (2)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
    Date of First Response: