Uploaded image for project: 'XWiki Eclipse'
  1. XWiki Eclipse
  2. XECLIPSE-117

Drill Down helper methods in Summaries

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • None
    • XEclipse
    • None
    • Checked out from head on November 3.

    Description

      Hi,

      I haven't done a whole lot of eclipse development, but I started browsing through xeclipse and I came across a couple of lines that I found hard to parse.
      e.g.
      List<XWikiEclipseObjectSummary> result =
      pageSummary.getDataManager().getObjects(pageSummary.getData().getId());

      I thought that a helper method in the XWikiEclipseSpaceSummary and XWikiEclipsePageSummary classes would improve the readability of these lines.

      So I have implemented getPageSummaries() and getObjectSummaries() methods respectively and adjusted the relevent uiAdapters to call these helper methods.
      This does introduce a bit of coupling from upper to lower classes in the drilldown hierarchy, however I think that the readability improvement and the fact that the pargeSummary / spaceSummary variable is referred to only once in the calling statement make it worthwhile.

      I will attach patch files for the org.xwiki.eclipse.core and org.xwiki.eclipse.ui projects for this small change, hopefully you incorporate it.

      Regards,
      Neil Crow.

      P.S. I am really looking forward to XWikiClass creation and manipulation within XEclipse, followed by wizard functionality for creating XWiki-applications that adhere to standards driven by templates. I think this feature would greatly boost the number of XWiki applications being developed because it would be so much easier. Is this in the scope of your plans for XEclipse?

      Final question, what is the relation to confluence in the default connection string (http://localhost:8080/xwiki/xmlrpc/confluence)?
      I found this on the extension homepage http://code.xwiki.org/xwiki/bin/view/Extensions/XEclipseExtension under the heading "New connection wizard".

      Attachments

        Activity

          People

            Unassigned Unassigned
            neil.crow Neil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated: