Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-17018

Warnings for deprecated usage of parameters on Deleted Pages and Deleted Attachments livetables

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 12.1-rc-1, 11.10.4
    • 11.7-rc-1, 11.10.2
    • None
    • None
    • Windows 10 Pro 64 bit, Firefox 72, using a local instance of XWiki 11.10.2 on Oracle 19c
    • Unknown
    • N/A
    • N/A

    Description

      STEPS TO REPRODUCE

      1. Delete some pages
      2. Delete some attachments
      3. Go to Drawer > Page Index > Deleted Pages tab
      4. Click on 'Deleted on' filter and select 'Yesterday' for ex.
      5. Go to Deleted Attachments tab and select 'Yesterday' for ex. as well
      6. Observe the XWiki console

      EXPECTED RESULTS

      No warnings/errors are displayed.

      ACTUAL RESULTS

      Some warnings are displayed related to deprecated usage of HQL parameters every time a date filter is applied:

      For Deleted Pages:

      2020-02-03 12:24:24,868 [http://localhost:1110/xwiki/bin/view/XWiki/DeletedDocumentsJSON?list=1&xpage=plain&outputSyntax=plain&offset=1&limit=15&reqNo=4&ddoc.date=1580594400000-1580680799999&&sort=ddoc.fullName&dir=asc] WARN  c.x.x.XWiki                    - Deprecated usage legacy-style HQL ordinal parameters (`?`); use JPA-style ordinal parameters (e.g., `?1`) instead. Query [select ddoc.id from XWikiDeletedDocument as ddoc where 1=1  and ddoc.date between ? and ?  order by ddoc.fullName asc] has been converted to [select ddoc.id from XWikiDeletedDocument as ddoc where 1=1  and ddoc.date between ?1 and ?2  order by ddoc.fullName asc]
2020-02-03 12:24:24,871 [http://localhost:1110/xwiki/bin/view/XWiki/DeletedDocumentsJSON?list=1&xpage=plain&outputSyntax=plain&offset=1&limit=15&reqNo=4&ddoc.date=1580594400000-1580680799999&&sort=ddoc.fullName&dir=asc] WARN  c.x.x.XWiki                    - Deprecated usage legacy-style HQL ordinal parameters (`?`); use JPA-style ordinal parameters (e.g., `?1`) instead. Query [select count(*) from XWikiDeletedDocument as ddoc where 1=1  and ddoc.date between ? and ? ] has been converted to [select count(*) from XWikiDeletedDocument as ddoc where 1=1  and ddoc.date between ?1 and ?2 ]

      For Deleted Attachments:

      2020-02-03 12:24:24,868 [http://localhost:1110/xwiki/bin/view/XWiki/DeletedDocumentsJSON?list=1&xpage=plain&outputSyntax=plain&offset=1&limit=15&reqNo=4&ddoc.date=1580594400000-1580680799999&&sort=ddoc.fullName&dir=asc] WARN  c.x.x.XWiki                    - Deprecated usage legacy-style HQL ordinal parameters (`?`); use JPA-style ordinal parameters (e.g., `?1`) instead. Query [select ddoc.id from XWikiDeletedDocument as ddoc where 1=1  and ddoc.date between ? and ?  order by ddoc.fullName asc] has been converted to [select ddoc.id from XWikiDeletedDocument as ddoc where 1=1  and ddoc.date between ?1 and ?2  order by ddoc.fullName asc]
2020-02-03 12:24:24,871 [http://localhost:1110/xwiki/bin/view/XWiki/DeletedDocumentsJSON?list=1&xpage=plain&outputSyntax=plain&offset=1&limit=15&reqNo=4&ddoc.date=1580594400000-1580680799999&&sort=ddoc.fullName&dir=asc] WARN  c.x.x.XWiki                    - Deprecated usage legacy-style HQL ordinal parameters (`?`); use JPA-style ordinal parameters (e.g., `?1`) instead. Query [select count(*) from XWikiDeletedDocument as ddoc where 1=1  and ddoc.date between ? and ? ] has been converted to [select count(*) from XWikiDeletedDocument as ddoc where 1=1  and ddoc.date between ?1 and ?2 ]

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-16534 Warnings related to deprecated usage of parameters when accessing WikiManager page

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. XWIKI-16536 Convert livetable queries to not use old ? based hql parameters

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-17065 Warnings for deprecated usage of HQL ordinal parameters when removing a deleted attachment

          • Major - Major loss of function.
          • Closed

          Activity

            People

              tmortagne Thomas Mortagne
              iandriuta Ilie Andriuta
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: