Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-17642

Take debug configuration into account when retrieving skin files

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 12.6
    • Fix Version/s: 12.7-rc-1
    • Component/s: Old Core
    • Labels:
      None
    • Tests:
      Unit
    • Difficulty:
      Medium
    • Similar issues:

      Description

      ATM we bundle only the minified JavaScript and CSS files in the XWiki WAR but I'm going to change that with XWIKI-13775 so we should modify getSkinFile to take into account the debug configuration when computing the path to the skin file. If minification is on it should look for the minified version. Otherwise it should look for the unminified version. This would ease a lot the debugging of an XWiki instance because adding ?minify=true to the URL will be taken into account by skin files also not just JSX and SSX.

      Next step would be to modify the WebJar module to take into account the debug configuration so that we don't have to write IFs with $services.debug.minify in our pages or Velocity templates.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mflorea Marius Dumitru Florea
                Reporter:
                mflorea Marius Dumitru Florea
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Date of First Response: