Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-17890

Bad exception handling when a ResourceReferenceHandler fails

    Details

    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Documentation in Release Notes:
      N/A
    • Similar issues:

      Description

      Right now we just log an error and fall-back on the old action. However that doesn't make any sense because:
      1) There's no old action associated with this URL type (that's why a ResourceReferenceHandler was used in the first place), and thus it falls back on ViewAction which is not going to do what was expected for sure.
      2) We don't know the state of the servlet output response at this stage and more generally the state of XWiki and we cannot assume all is fine.

      Thus the only valid option is to throw an exception.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vmassol Vincent Massol
                Reporter:
                vmassol Vincent Massol
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours
                  2h