XWiki Platform
  1. XWiki Platform
  2. XWIKI-1862

Rights Manager Interface fixed css and xhtml validation

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.2, 1.2 M2
    • Fix Version/s: 1.2 RC1
    • Labels:
      None
    • keywords:
      rights manager, css, xhtml, valid
    • Similar issues:

      Description

      The css and xhtml had some problems that prevented the validation:

      • unescaped "&" entities
      • the css used for the lightbox contained invalid css hacks

      Fixes:

      • escaped "&"
      • wrote 2 separate css sheets for ie and other browsers, deleted the hacks for transparent background in lightbox by using a png back image (for browsers supporting png alpha transparency); for ie there is no other way that to use "filter" and "opacity" hacks.

        Issue Links

          Activity

          Hide
          Thomas Mortagne added a comment -

          Evelina there is problems in your patch, I can't apply : you did not make it from updated svn it seems.

          I could have corrected this but when I'm looking I see problems in you velocity code : for example you replace

          var chbx1 = new MSCheckbox(document.getElementById('tdview'), "view", "$

          {saveUrl}

          ", "$

          {r1}");

          by

          var chbx1 = new MSCheckbox(document.getElementById('tdview'), "view", saveUrl, "${r1}

          ");

          so you have saveUrl with no $

          Show
          Thomas Mortagne added a comment - Evelina there is problems in your patch, I can't apply : you did not make it from updated svn it seems. I could have corrected this but when I'm looking I see problems in you velocity code : for example you replace var chbx1 = new MSCheckbox(document.getElementById('tdview'), "view", "$ {saveUrl} ", "$ {r1}"); by var chbx1 = new MSCheckbox(document.getElementById('tdview'), "view", saveUrl, "${r1} "); so you have saveUrl with no $
          Hide
          evely24 added a comment -

          That example is correct,Thomas, as saveUrl is a javascript variable in the second case, not a velocity one anymore. Anyway, indeed I had a conflict in the patch even if I updated from the svn. I remade it and should work.

          Show
          evely24 added a comment - That example is correct,Thomas, as saveUrl is a javascript variable in the second case, not a velocity one anymore. Anyway, indeed I had a conflict in the patch even if I updated from the svn. I remade it and should work.
          Hide
          Thomas Mortagne added a comment -

          Apply Evelina's patch without modifications in 1.2 branch. Waiting for 1.1 patch to close.

          Show
          Thomas Mortagne added a comment - Apply Evelina's patch without modifications in 1.2 branch. Waiting for 1.1 patch to close.
          Hide
          evely24 added a comment -

          The patch for 1.1 is attached.

          Show
          evely24 added a comment - The patch for 1.1 is attached.
          Hide
          Thomas Mortagne added a comment -

          Apply Evelina's patch without modifications

          Show
          Thomas Mortagne added a comment - Apply Evelina's patch without modifications

            People

            • Assignee:
              Evelina Petronela Vrabie
              Reporter:
              Evelina Petronela Vrabie
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: