Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-21823

Tour javascript is loaded even when there is no active tours

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • 15.10.5
    • Tour
    • Unknown
    • Awaiting Committer feedback

    Description

      Note: the affect version needs to be refined

      Reproduction steps

      1. Go to http://localhost:8080/xwiki/bin/view/Tour/
      2. Edit all listed tours and uncheck "activate"
      3. Go to any page with the browser debug tool opened
      4. Check the network tab

      Expected

      No "tour" related http requests can be found

      Actual

      The following requests are made:

       
      Also, if all the tours are loaded for a given user, there is no need to load them again.
       

      Possible approaches:

      1. very fine-grained and only load the js for a given page if at least one tour or one step of a tour targets the current page with the right action etc...
      2. load the js everywhere as long as at least one tour is activated (not so great but a least the tour won't be loaded when it's strictly useless)

      Attachments

        Activity

          People

            mleduc Manuel Leduc
            mleduc Manuel Leduc
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: