XWiki Platform
  1. XWiki Platform
  2. XWIKI-5691

Macro output in not protected in WebKit-based and Opera browsers

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.4
    • Fix Version/s: 3.0 M3
    • Component/s: WYSIWYG Editor
    • Labels:
      None
    • Environment:
      epiphany browser (ubuntu 10.04)
      "Mozilla/5.0 (X11; U; Linux x86_64; de-de) AppleWebKit/531.2+ (KHTML, like Gecko) Version/5.0 Safari/531.2+ Ubuntu/10.04 LTS () Epiphany/2.30.2"
    • Development Priority:
      High
    • Difficulty:
      Hard
    • Similar issues:

      Description

      Try to edit the content of an existing code macro in the WYSIWYG editor.
      If you press the "save" button or change to the "source" editor the modification are lost

        Issue Links

          Activity

          Hide
          Marius Dumitru Florea added a comment -

          You are editing the code macro in-line right? The output of any macro must be protected (i.e. read-only) because macros are transformations and you have to edit the source of the transformation not the result. Unfortunately macro output is currently unprotected in WebKit-based browsers (like Epiphany). This should be fixed soon (I have a fix, I just need to find the time to properly test and commit it). Sorry for the inconvenience.

          Show
          Marius Dumitru Florea added a comment - You are editing the code macro in-line right? The output of any macro must be protected (i.e. read-only) because macros are transformations and you have to edit the source of the transformation not the result. Unfortunately macro output is currently unprotected in WebKit-based browsers (like Epiphany). This should be fixed soon (I have a fix, I just need to find the time to properly test and commit it). Sorry for the inconvenience.
          Hide
          Marius Dumitru Florea added a comment -

          I plan to fix this issue in 3.0 (it requires a refactoring of the way macros are displayed in WYSIWYG mode, using contentEditable attribute instead of an HTML button; I have it locally but I can't commit it in 2.7 because it's a stabilisation release).

          Show
          Marius Dumitru Florea added a comment - I plan to fix this issue in 3.0 (it requires a refactoring of the way macros are displayed in WYSIWYG mode, using contentEditable attribute instead of an HTML button; I have it locally but I can't commit it in 2.7 because it's a stabilisation release).

            People

            • Assignee:
              Marius Dumitru Florea
              Reporter:
              H.-Dirk Schmitt
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: