XWiki Platform

Add support for relative links/images in included documents

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.7 RC1
  • Fix Version/s: 3.0 M1
  • Component/s: {Unused} Rendering 2.0
  • Labels:
    None
  • Tests:
    Unit
  • Difficulty:
    Unknown
  • Similar issues:
    XWIKI-5902Add support for relative links/images in included documents when they are generated by macros
    XWIKI-5808Include Macro doesn't resolve relative attachments and relative images
    XWIKI-3875Always add relative references from the Wysiwyg link / image wizards
    XWIKI-5554Generalize Image support and add relative paths support for XWiki Syntax 2.1
    XWIKI-3611Add support for relative paths in Link in XWiki Syntax 2.1
    XWIKI-1646Copy document with included content
    XWIKI-6645Add support for more date related methods in XWQL language
    XWIKI-1776Support Include of Section Content
    XWIKI-1648Copy and save document with included content
    XWIKI-3524Add support for splitting document imports

Description

This means that they should be resolved with the included document as the reference.

Maybe add a macro parameter to disable this if the user really wants the link to be resolved against the including document (there may be use cases for that).

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. XWIKI-5808 Include Macro doesn't resolve relative attachments and relative images

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. XWIKI-6196 Links to attached images are broken on included pages

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.
relates to

Improvement - An improvement or enhancement to an existing feature or task. XWIKI-5902 Add support for relative links/images in included documents when they are generated by macros

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Massol added a comment -

First implementation committed. Limitation: doesn't work when links/images are located inside a macro in the included document. To support this we need XWIKI-4802

Show
Vincent Massol added a comment - First implementation committed. Limitation: doesn't work when links/images are located inside a macro in the included document. To support this we need XWIKI-4802
Hide
Permalink
Vincent Massol added a comment -

First implementation done for 3.0M1. The improved solution should be implemented at XWIKI-5902

Show
Vincent Massol added a comment - First implementation done for 3.0M1. The improved solution should be implemented at XWIKI-5902

People

  • Assignee:
    Vincent Massol
    Reporter:
    Vincent Massol
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: