XWiki Platform

Deleted attachments duplication in recycle bin while File Storage is on

Details

  • keywords:
    recycle bin, attachment, file storage system, FS
  • Difficulty:
    Unknown
  • Documentation:
    N/A
  • Documentation in Release Notes:
    N/A
  • Similar issues:
    XWIKI-6951When using filesystem attachments with attachment versioning disabled, deleted attachments are duplicated on the hard disk.
    XWIKI-6918Empty search results of attachments live table while file system storage turned on in multi-wiki mode
    XWIKI-543Recycle bin for deleted documents
    XWIKI-2345UI for managing the Recycle Bins
    XWIKI-6071Add filesystem based attachment recycle bin store.
    XWIKI-7399Empty search results of deleted attachments in live table while file system storage turned on
    XWIKI-7978File system attachment store recycle bin sometimes fails to list deleted attachments.
    XWIKI-1641Add preview possibility for deleted documents from recycle bin
    XWIKI-1893When a document is restored from the recycle bin it should be removed from the recycle bin
    XWIKI-2085Deleting all the revisions should move the whole document to the recycle bin

Description

Attachment versioning turned off (xwiki.store.attachment.versioning.hint = void)
Storage is set to file system,
Recycle Bin is ON.

To verify attachment versioning is off. The same file attachment several times gives one copy in storage as expected. No problem.

If user deletes an attachment.
Expected behaviour: just to MOVE attachment to recycle bin via file system opertaion. Usually takes milliseconds to complete.

Real behaviour:
~GLOBAL_DELETED_ATTACHMENT_ID_MAPPINGS.xml appeared in /store folder.
XML inside shows were to find files. Files are on their places as described.

BUT

Recycle bin gives terrible surprise: it stores TWO COPIES of deleted file:
first is: <filename>.<extension>
second is: <filename>~v1.1.<extension>

Please note, that attachment VERSIONING is turned OFF.

For big attachments (1GB and more) such a behaviour is a disaster for two reasons:

  • unreasonable disk space consumption
  • huge delay while user deleting attachment (move+copy)

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. XWIKI-6951 When using filesystem attachments with attachment versioning disabled, deleted attachments are duplicated on the hard disk.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
CalebJamesDeLisle added a comment -

not critical, system functions as expected but less efficiently.

Show
CalebJamesDeLisle added a comment - not critical, system functions as expected but less efficiently.
Hide
Permalink
Sergiu Dumitriu added a comment -

Fixed in c9f4499

I used a quick hack, if the archive to save is instanceof VoidAttachmentArchive, then skip saving the archive.

Show
Sergiu Dumitriu added a comment - Fixed in c9f4499 I used a quick hack, if the archive to save is instanceof VoidAttachmentArchive , then skip saving the archive.

People

  • Assignee:
    Sergiu Dumitriu
    Reporter:
    Dmitry Bakbardin
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
    Date of First Response: