XWiki Platform

Improve gadget's container styling in INLINE mode to better suggest dragging and delimitation

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 4.0-milestone-1
  • Fix Version/s: 4.3-milestone-1
  • Component/s: Dashboard
  • Labels:
    None
  • Difficulty:
    Unknown
  • Documentation:
    N/A
  • Documentation in Release Notes:
    N/A
  • Similar issues:
    XWIKI-6115Include instructions on how to drag and drop gadgets.
    XWIKI-8497The gadget isn't visible when I try to drag and drop it elsewhere using "Inline form" on IE9
    XWIKI-7557Problems when editing Main.WebHome in Inline edit mode
    XWIKI-6620Can't add gadget or edit gadget parameters
    XWIKI-6160Cannot "cancel" adding a gadget on a dashboard, or removing a gadget or editing the parameters of a gadget
    XWIKI-6038Small suggest style improvements
    XWIKI-6114Improvements on the Add Gadget and Add Column button
    XWIKI-6084Adding a gadget to an empty dashboard fails with a javascript error
    XWIKI-5843Columns layout for container macro should not use inline styles
    XWIKI-6100Search suggest widget improvements

Description

Our dashboard is much nicer than other dashboards because is focused on the content and not on the independence of its elements. This means that you can combine gadgets in order to create a content page that is unified, and you are not just displaying together different/independent elements.
That's why in view mode is important that the gadgets are mixed together and are invisible.

When you edit the dashboard it's another story. The gadgets should be easy to be identified since they have independent settings.

In 3.0 when we introduced the Dashboard we had a 'panels' style for the dashboard container. The difference from that approach is:

  • the additional style is available just in INLINE mode
  • the title is inside the content so that we preserve the WYSIWYG feeling
  • macro's 'cog' icon and heading is visible in order to delimit the gadget. Helps delimitation, dragging, spotting of the settings entry
  1. afterProposal.png
    160 kB
    03/Apr/12 15:08
  2. beforeProposal.png
    139 kB
    03/Apr/12 15:08
  3. currentPanels.png
    78 kB
    03/Apr/12 15:08
  4. dashboardAfter.png
    99 kB
    29/Jun/12 13:23
  5. fail.png
    43 kB
    22/Oct/12 14:44
  6. Implemented.png
    168 kB
    14/Dec/12 12:48
  7. inlineActiononTop.png
    49 kB
    20/Jun/12 16:29
  8. pass.png
    42 kB
    22/Oct/12 14:44

Issue Links

blocks

Improvement - An improvement or enhancement to an existing feature or task. XWIKI-7685 Improve Homepage editing and Dashboard 'included' message

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.
is related to

Improvement - An improvement or enhancement to an existing feature or task. XWIKI-6115 Include instructions on how to drag and drop gadgets.

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Open - The issue is open and ready for the assignee to start work on it.
relates to

Bug - A problem which impairs or prevents the functions of the product. XWIKI-7995 Panel style parameter does not have gradients

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ecaterina Moraru (Valica) added a comment -

Another improvements could be to display the gadget's actions inline in order to save a hover+click, especially since the hover area that triggers the menu is just 16px.

Having the title inside, the actions have enough space to be displayed.

Show
Ecaterina Moraru (Valica) added a comment - Another improvements could be to display the gadget's actions inline in order to save a hover+click, especially since the hover area that triggers the menu is just 16px. Having the title inside, the actions have enough space to be displayed.
Hide
Permalink
Ecaterina Moraru (Valica) added a comment -

Proposal at http://incubator.myxwiki.org/xwiki/bin/view/Improvements/HomepageContent#HDashboardEdit

Show
Ecaterina Moraru (Valica) added a comment - Proposal at http://incubator.myxwiki.org/xwiki/bin/view/Improvements/HomepageContent#HDashboardEdit
Hide
Permalink
Vincent Massol added a comment -

JV, it seems you may have broken the build with your commit for this issue, see http://ci.xwiki.org/view/Platform/job/xwiki-platform/2736/consoleFull

Show
Vincent Massol added a comment - JV, it seems you may have broken the build with your commit for this issue, see http://ci.xwiki.org/view/Platform/job/xwiki-platform/2736/consoleFull
Hide
Permalink
Ecaterina Moraru (Valica) added a comment - - edited

After XWIKI-7415 the Dashboard works both by using "edit" mode and also "inline" mode.
This fix covers just the "inline" mode by using special CSS class ".inlinebody", but it will fail for the other mode.

For example:
FAIL "Main.WebHome -> Edit (advanced user) -> Inline form" = /xwiki/bin/edit/Main/WebHome?editor=inline https://skitch.com/risherry/e27ij/fail
PASS "Dashboard.WebHome -> Edit" = /xwiki/bin/inline/Dashboard/WebHome https://skitch.com/risherry/e27ix/pass
PASS "Dashboard.WebHome -> Edit (advanced user) -> Inline form" = /xwiki/bin/inline/Dashboard/WebHome?editor=inline

IMO we should also fix the "edit" mode especially since there are better chances to want to edit the Dashboard from being on the homepage.

Show
Ecaterina Moraru (Valica) added a comment - - edited After XWIKI-7415 the Dashboard works both by using "edit" mode and also "inline" mode. This fix covers just the "inline" mode by using special CSS class ".inlinebody", but it will fail for the other mode. For example: FAIL "Main.WebHome -> Edit (advanced user) -> Inline form" = /xwiki/bin/edit/Main/WebHome?editor=inline https://skitch.com/risherry/e27ij/fail PASS "Dashboard.WebHome -> Edit" = /xwiki/bin/inline/Dashboard/WebHome https://skitch.com/risherry/e27ix/pass PASS "Dashboard.WebHome -> Edit (advanced user) -> Inline form" = /xwiki/bin/inline/Dashboard/WebHome?editor=inline IMO we should also fix the "edit" mode especially since there are better chances to want to edit the Dashboard from being on the homepage.
Hide
Permalink
Vincent Massol added a comment -

If this issue created a regression (ie something that was working is not working anymore) then it should definitely be fixed and even marked as a Blocker (bad with the release happening today). JV, can you comment please?

Show
Vincent Massol added a comment - If this issue created a regression (ie something that was working is not working anymore) then it should definitely be fixed and even marked as a Blocker (bad with the release happening today). JV, can you comment please?
Hide
Permalink
Jean-Vincent Drean added a comment -

It's not a blocker at all but I'll fix it asap

Show
Jean-Vincent Drean added a comment - It's not a blocker at all but I'll fix it asap

People

  • Assignee:
    Jean-Vincent Drean
    Reporter:
    Ecaterina Moraru (Valica)
Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved:
    Date of First Response: