XWiki Platform

documentAccessBridge.getAttachmentURL(AttachmentReference,true) not returning the FULL URL

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Blocker Blocker
  • Resolution: Unresolved
  • Affects Version/s: 4.1.2
  • Fix Version/s: 5.1-rc-1
  • Component/s: Bridge
  • Labels:
    None
  • Difficulty:
    Unknown
  • Similar issues:
    XWIKI-1834XWikiDocument.toString() should return the document's full name
    XWIKI-895Add a getExternalURL to get the a full URL
    XWIKI-437Improve URL factories and create a xwiki-url module for manipulating XWiki URLs
    XWIKI-2026The API version of xwiki.clearName() does not return a valid (for URL) page name
    XWIKI-1807getServerURL(db, context) not including port number when returning the URL (virtual or main wiki)
    XWIKI-889XWikiServletURLFactory.createExternalURL create internal URL
    XWIKI-6470Add an API to return all full names of documents that contains a job object
    XWIKI-5482URIClassLoader#findResources can return infinite Enumeration
    XWIKI-8204The link from the space index macro to the full space index is wrong when the space name contains special URL characters
    XWIKI-1928XWiki returns invalid URLs when the server port is not defined (i.e. when it's 80)

Description

documentAccessBridge.getAttachmentURL(AttachmentReference,true) is returning the relative URL instead of full URL

Issue Links

links to

Web Link Documentation link

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Massol added a comment -

That's not a bug. All our get URL methods return relative URLs except getExternalURL. Why do you consider it a bug?

Show
Vincent Massol added a comment - That's not a bug. All our get URL methods return relative URLs except getExternalURL. Why do you consider it a bug?
Hide
Permalink
Savitha Sundaramoorthi added a comment - - edited

Hi,

I was going through this documentation.

http://maven.xwiki.org/site/xwiki-commons-pom/xwiki-platform/xwiki-platform-core/xwiki-platform-bridge/apidocs/org/xwiki/bridge/DocumentAccessBridge.html

It said that it retrieves the URL (either relative ie the path without the hostname and port, or the full URL) that can be used to access an attachment. Asked the doubt in IRC and came to a conclusion that it might be a bug.

Show
Savitha Sundaramoorthi added a comment - - edited Hi, I was going through this documentation. http://maven.xwiki.org/site/xwiki-commons-pom/xwiki-platform/xwiki-platform-core/xwiki-platform-bridge/apidocs/org/xwiki/bridge/DocumentAccessBridge.html It said that it retrieves the URL (either relative ie the path without the hostname and port, or the full URL) that can be used to access an attachment. Asked the doubt in IRC and came to a conclusion that it might be a bug.
Hide
Permalink
Vincent Massol added a comment -

Ah sorry, indeed if you pass "true" as the second param of getAttachmentURL you should get an absolute URL.

Show
Vincent Massol added a comment - Ah sorry, indeed if you pass "true" as the second param of getAttachmentURL you should get an absolute URL.
Hide
Permalink
Vincent Massol added a comment -

This looks like a regression somewhere...

Show
Vincent Massol added a comment - This looks like a regression somewhere...
Hide
Permalink
Denis Gervalle added a comment -

Confirmed, here is a quick test (you need a attachement on the current document):

{{groovy}}
  def docbridge = services.component.getComponentManager().getInstance(org.xwiki.bridge.DocumentAccessBridge.class);
  def attachRef = docbridge.getAttachmentReferences(docbridge.getCurrentDocumentReference()).iterator().next();
  println(docbridge.getAttachmentURL(attachRef, true));
{{/groovy}}
Show
Denis Gervalle added a comment - Confirmed, here is a quick test (you need a attachement on the current document): {{groovy}} def docbridge = services.component.getComponentManager().getInstance(org.xwiki.bridge.DocumentAccessBridge.class); def attachRef = docbridge.getAttachmentReferences(docbridge.getCurrentDocumentReference()).iterator().next(); println(docbridge.getAttachmentURL(attachRef, true)); {{/groovy}}

People

  • Assignee:
    Unassigned
    Reporter:
    Savitha Sundaramoorthi
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Date of First Response: