Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-8412

URLPatternMatcher instances cannot be reused on different strings.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.3-milestone-1
    • Fix Version/s: 4.3-milestone-2
    • Component/s: Old Core
    • Labels:
      None
    • Difficulty:
      Trivial
    • Documentation:
      N/A
    • Similar issues:

      Description

      URLPatternMatcher instances cannot generally be reused (because the underlaying Perl5Matcher cannot be reused) on different strings and with different patterns and a new instance must be produced on demand. It is, thus, meaningless to set an instance. If there is any code relying on this method, it is broken already. Thus, we should remove this without going through deprecation. The only place where getUrlPatternMatcher is used in core appears to be in XWikiAuthServiceImpl in processLogout. This method appears to fail occasionally because the urlPatternMatcher instance is reused. See: http://ci.xwiki.org/job/xwiki-enterprise-test-ui/org.xwiki.enterprise$xwiki-enterprise-test-ui/1746/console

        Attachments

          Activity

            People

            • Assignee:
              aj Andreas Jonsson
              Reporter:
              aj Andreas Jonsson
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: