XWiki Platform

Duplication entries check bug in an application created by Application Within Minutes

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.3-rc-1
  • Fix Version/s: 3.3
  • Component/s: Old Core
  • Labels:
    None
  • Environment:
    Standalone XWiki, Windows
  • keywords:
    Application Within Minutes, bug, duplication check
  • Tests:
    Unit
  • Difficulty:
    Easy
  • Similar issues:
    XWIKI-7562Application created by Application Within Minutes always shows unnecessary "edit class" link regardles to access rights
    XWIKI-7563Application created by Application Within Minutes cuts "?" both in page names and page titles
    XWIKI-7868PDF Export of document created with app within minutes only displays values of fields (no labels)
    XWIKI-8757Support 2 roles for users for app within minutes: application creator and data creator
    XWIKI-7110Implement a first version of the class editor that will be used by App Within Minutes
    XWIKI-7927Create an entry point for all available applications inside the wiki
    XWIKI-7190Create the AppWithinMinutes wizard
    XWIKI-7532UI Issue on WYSIWYG Editor when editing Application Class
    XWIKI-8430Missing some livetable translations in the WebHome of applications created with AppWithinMinutes
    XWIKI-9113Dashboard created with App Within Minutes not loading after upgrade to 5.0

Description

Any attempt to make duplication entry gives an error described below. No correct duplication check is done.
How to reproduce:

  • make any application
  • make an entry
  • try to make another entry with the same name.
  • follow the error code:

Error number 0 in 11: Uncaught exception
Wrapped Exception: null
com.xpn.xwiki.XWikiException: Error number 0 in 11: Uncaught exception
Wrapped Exception: null
at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:252)
at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:116)
at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:236)
at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196)
at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:538)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1352)
at com.xpn.xwiki.web.ActionFilter.doFilter(ActionFilter.java:128)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1323)
at org.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:144)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1323)
at com.xpn.xwiki.plugin.webdav.XWikiDavFilter.doFilter(XWikiDavFilter.java:68)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1323)
at org.xwiki.container.servlet.filters.internal.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:217)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1323)
at org.xwiki.container.servlet.filters.internal.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:109)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1323)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:476)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:119)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:517)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:225)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:937)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:406)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:183)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:871)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117)
at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:247)
at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:149)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:110)
at org.eclipse.jetty.server.Server.handle(Server.java:346)
at org.eclipse.jetty.server.HttpConnection.handleRequest(HttpConnection.java:589)
at org.eclipse.jetty.server.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:1048)
at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:601)
at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:214)
at org.eclipse.jetty.server.HttpConnection.handle(HttpConnection.java:411)
at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:535)
at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:40)
at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:529)
at java.lang.Thread.run(Unknown Source)

Wrapped Exception:

java.util.ConcurrentModificationException
at java.util.AbstractList$Itr.checkForComodification(Unknown Source)
at java.util.AbstractList$Itr.next(Unknown Source)
at com.xpn.xwiki.doc.XWikiDocument.setXObjects(XWikiDocument.java:2089)
at com.xpn.xwiki.doc.XWikiDocument.mergeXObjects(XWikiDocument.java:2437)
at com.xpn.xwiki.doc.XWikiDocument.readFromTemplate(XWikiDocument.java:3271)
at com.xpn.xwiki.doc.XWikiDocument.readFromTemplate(XWikiDocument.java:3289)
at com.xpn.xwiki.doc.XWikiDocument.readFromTemplate(XWikiDocument.java:3224)
at com.xpn.xwiki.web.EditAction.render(EditAction.java:117)
at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:229)
at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:116)
at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:236)
at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196)
at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:538)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1352)
at com.xpn.xwiki.web.ActionFilter.doFilter(ActionFilter.java:128)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1323)
at org.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:144)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1323)
at com.xpn.xwiki.plugin.webdav.XWikiDavFilter.doFilter(XWikiDavFilter.java:68)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1323)
at org.xwiki.container.servlet.filters.internal.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:217)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1323)
at org.xwiki.container.servlet.filters.internal.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:109)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1323)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:476)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:119)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:517)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:225)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:937)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:406)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:183)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:871)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117)
at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:247)
at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:149)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:110)
at org.eclipse.jetty.server.Server.handle(Server.java:346)
at org.eclipse.jetty.server.HttpConnection.handleRequest(HttpConnection.java:589)
at org.eclipse.jetty.server.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:1048)
at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:601)
at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:214)
at org.eclipse.jetty.server.HttpConnection.handle(HttpConnection.java:411)
at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:535)
at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:40)
at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:529)
at java.lang.Thread.run(Unknown Source)

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. XWIKI-7262 XWikiDocument#setXObjects is adding provided object instead of setting them

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. XWIKI-7439 Category becomes invisible when adding a subcategory with the same name as parent category

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct and has been pushed to production. Issues which are not closed can be reopened.

Activity

Hide
Permalink
Marius Dumitru Florea added a comment -

The problem is not specific to the App Within Minutes module. It's a generic problem that can be reproduced by trying to apply twice a template (with objects) to a document(i.e. apply the template again after it was used to create the document). I see three issues:

  1. XWikiDocument#readFromTemplate applies the template even if the document is not new (because the content of the document is empty, but that is normal since the document content is not used anymore to apply the object sheet, i.e. there is no include macro in the document content)
  2. XWikiDocument#mergeXObjects uses XWikiDocument#setXObjects instead of simply using XWikiDocument#addXObject to copy the objects from the template to the target document.
  3. XWikiDocument#setXObjects is adding the provided objects instead of setting them. See XWIKI-7262.

I'm going to fix XWikiDocument#mergeXObjects. The effect for the App Within Minutes will be that you will edit the existing entry when trying to add a new one with the same name.

Show
Marius Dumitru Florea added a comment - The problem is not specific to the App Within Minutes module. It's a generic problem that can be reproduced by trying to apply twice a template (with objects) to a document(i.e. apply the template again after it was used to create the document). I see three issues: XWikiDocument#readFromTemplate applies the template even if the document is not new (because the content of the document is empty, but that is normal since the document content is not used anymore to apply the object sheet, i.e. there is no include macro in the document content) XWikiDocument#mergeXObjects uses XWikiDocument#setXObjects instead of simply using XWikiDocument#addXObject to copy the objects from the template to the target document. XWikiDocument#setXObjects is adding the provided objects instead of setting them. See XWIKI-7262 . I'm going to fix XWikiDocument#mergeXObjects . The effect for the App Within Minutes will be that you will edit the existing entry when trying to add a new one with the same name.

People

  • Assignee:
    Marius Dumitru Florea
    Reporter:
    Dmitry Bakbardin
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
    Date of First Response: