Uploaded image for project: 'Admin Tools Application'
  1. Admin Tools Application
  2. ADMINTOOL-99

Shrinking the recycle bins compares the deletion date with a string

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • 4.5.7
    • Data altering tool
    • None
    • Unknown

    Description

      Admin.ShrinkRecycleBins compares the deletion date of the deleted documents and attachments with a string, in 3 queries:

      select count(doc) from XWikiDeletedDocument doc where doc.date < '${getAgeWhereClause(age)}'
      select count(doc) from DeletedAttachment doc where doc.date < '${getAgeWhereClause(age)}'
      select doc.fullName from XWikiDeletedDocument doc where doc.date < '${getAgeWhereClause(0)}'
      

      Since Hibernate 6, HQL checks the types of both sides of a comparison when the query is parsed, and rejects incompatible ones (SemanticException: Cannot compare left expression of type ... with right expression of type ...). XWiki is moving to Hibernate 7 (XWIKI-19708), where these queries will fail on every database. With Hibernate 5 the literal is copied as is in the SQL, so the queries rely on the database converting it implicitly, which not all databases do.

      On Oracle, this already depends on the date format of the database session (NLS_DATE_FORMAT).

      Bind the date as a java.util.Date query parameter instead. This works with all the databases and all the Hibernate versions.

      PS: This post was co-written with Claude Code.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              tmortagne Thomas Mortagne
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated: