Details
-
Bug
-
Resolution: Fixed
-
Major
-
1.17
-
None
-
None
-
High
-
Trivial
-
Description
I haven't reproduced this problem myself but I had users reporting this behavior and by looking at the code it seems plausible because when CKEdior is loaded we check if the office import feature is available. We do this by testing two conditions:
- if the office server is connected
- if we can import an empty file
#set ($emptyAttachmentReference = $services.model.resolveAttachment('CKEditor.OfficeImporter@empty.txt')) #set ($officeImporterSupported = $services.officemanager.serverState == 'Connected' && $services.wysiwyg.importOfficeAttachment($emptyAttachmentReference, {}).equals(''))
The first condition is mandatory and it should be evaluated instantly. The second condition is optional, and it can slow down or block the loading if the office server is busy (even if the file is empty the conversion goes through the office server which is the whole point of having this condition). The office server can be busy is many users are doing office imports or exports at the same time.
I think we can remove the second condition since it doesn't bring much. The user will get an error message on the Office import dialog if the server can't do the import which I guess is better than not showing the office import button at all and better than getting the spinning wheel while the editor is loading.
Attachments
Issue Links
- is related to
-
CKEDITOR-23 Add support for importing content from office documents
- Closed
-
XWIKI-14739 Add APIs for importing office files in the WYSIWYG editor
- Closed