Uploaded image for project: 'Change Request Application'
  1. Change Request Application
  2. CRAPP-303

Authors review are not counted in the approval strategy

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 1.10
    • 0.13
    • None
    • None
    • Unit
    • Unknown
    • N/A
    • N/A

    Description

      Reproduction steps:

      • Create a document with 2 approvers Foo and Bar
      • Enable the merge approval strategy " Require all approvers to approve (without fallback)"
      • Leave the option "Prevent authors from reviewing Change Requests they create" disabled
      • Login with Foo and open a new CR for the page created
      • Review the CR with Foo and approve it
      • Edit the CR again: the review should be invalidated now
      • Login with Bar an approve the CR previously created

      Expected result:

      • Since Foo's review is invalidated and both Foo and Bar are reviewers, the CR shouldn't be ready for merging

      Obtained result:

      • The CR is already ready for merging: actually, doing same steps but without any review from Foo lead to the same result. Basically only Bar's review is needed

      Attachments

        Issue Links

          Activity

            People

              surli Simon Urli
              surli Simon Urli
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: