Uploaded image for project: 'Change Request Application'
  1. Change Request Application
  2. CRAPP-391

Abusive modification of document in Change Request

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 1.18
    • 1.17
    • None
    • None
    • Unknown
    • N/A
    • N/A

    Description

      Obtained following stacktrace when editing description of a CR in XWiki 17.6.0:

      2025-07-30 14:40:40,561 [qtp1356728614-324 - http://localhost:8080/xwiki/changerequest/xwiki/save/CR1-4e8afea8-35ac-4fcf-9ec6-e88746101316?form_token=XRlULRnCcxx1YgEeCLwALA] WARN  c.x.x.d.XWikiDocument          - Abusive modification of the cached document [xwiki:ChangeRequest.Data.CR1-4e8afea8-35ac-4fcf-9ec6-e88746101316.WebHome()] 
      java.lang.IllegalStateException: Abusive modification of the cached document
      	at com.xpn.xwiki.doc.XWikiDocument.setMetaDataDirty(XWikiDocument.java:2460)
      	at com.xpn.xwiki.doc.XWikiDocument.setDate(XWikiDocument.java:2329)
      	at org.xwiki.contrib.changerequest.internal.storage.DefaultChangeRequestStorageManager.prepareChangeRequestDocument(DefaultChangeRequestStorageManager.java:254)
      	at org.xwiki.contrib.changerequest.internal.storage.DefaultChangeRequestStorageManager.save(DefaultChangeRequestStorageManager.java:224)
      	at org.xwiki.contrib.changerequest.internal.handlers.SaveChangeRequestHandler.handleDescriptionOrTitleUpdate(SaveChangeRequestHandler.java:168)
      	at org.xwiki.contrib.changerequest.internal.handlers.SaveChangeRequestHandler.handle(SaveChangeRequestHandler.java:92)
      	at org.xwiki.contrib.changerequest.internal.handlers.ChangeRequestResourceHandler.handle(ChangeRequestResourceHandler.java:139)
      

      Also happening when performing a review:

      2025-07-30 16:27:58,944 [qtp1356728614-602 - http://localhost:8080/xwiki/changerequest/xwiki/review/CR1-74d80ac7-e7f5-46ca-baf7-6fb2c07ef122] WARN  c.x.x.d.XWikiDocument          - Abusive modification of the cached document [xwiki:ChangeRequest.Data.CR1-74d80ac7-e7f5-46ca-baf7-6fb2c07ef122.WebHome()] 
      java.lang.IllegalStateException: Abusive modification of the cached document
      	at com.xpn.xwiki.doc.XWikiDocument.setMetaDataDirty(XWikiDocument.java:2460)
      	at com.xpn.xwiki.objects.BaseElement.setOwnerDocument(BaseElement.java:523)
      	at com.xpn.xwiki.objects.BaseCollection.addField(BaseCollection.java:546)
      	at com.xpn.xwiki.objects.BaseCollection.safeput(BaseCollection.java:272)
      	at com.xpn.xwiki.store.XWikiHibernateStore.saveXWikiCollection(XWikiHibernateStore.java:1492)
      	at com.xpn.xwiki.store.XWikiHibernateStore.saveXWikiDoc(XWikiHibernateStore.java:749)
      	at com.xpn.xwiki.store.XWikiCacheStore.saveXWikiDoc(XWikiCacheStore.java:277)
      	at com.xpn.xwiki.store.XWikiCacheStore.saveXWikiDoc(XWikiCacheStore.java:239)
      	at com.xpn.xwiki.XWiki.saveDocument(XWiki.java:2113)
      	at com.xpn.xwiki.XWiki.saveDocument(XWiki.java:2008)
      	at org.xwiki.contrib.changerequest.internal.storage.DefaultReviewStorageManager.save(DefaultReviewStorageManager.java:117)
      	at org.xwiki.contrib.changerequest.internal.DefaultChangeRequestManager.addReview(DefaultChangeRequestManager.java:219)
      	at org.xwiki.contrib.changerequest.internal.handlers.ReviewChangeRequestHandler.handle(ReviewChangeRequestHandler.java:101)
      	at org.xwiki.contrib.changerequest.internal.handlers.ChangeRequestResourceHandler.handle(ChangeRequestResourceHandler.java:139)
      

      Or when performing a rebase:

      java.lang.IllegalStateException: Abusive modification of the cached document
      	at com.xpn.xwiki.doc.XWikiDocument.setMetaDataDirty(XWikiDocument.java:2460)
      	at com.xpn.xwiki.objects.BaseElement.setOwnerDocument(BaseElement.java:523)
      	at com.xpn.xwiki.objects.BaseCollection.setOwnerDocument(BaseCollection.java:994)
      	at com.xpn.xwiki.objects.BaseObject.setOwnerDocument(BaseObject.java:424)
      	at com.xpn.xwiki.doc.XWikiDocument.createXObject(XWikiDocument.java:2998)
      	at org.xwiki.contrib.changerequest.internal.storage.DefaultFileChangeStorageManager.createFileChangeObject(DefaultFileChangeStorageManager.java:256)
      	at org.xwiki.contrib.changerequest.internal.storage.DefaultFileChangeStorageManager.save(DefaultFileChangeStorageManager.java:211)
      	at org.xwiki.contrib.changerequest.internal.storage.DefaultFileChangeStorageManager.rebase(DefaultFileChangeStorageManager.java:433)
      	at org.xwiki.contrib.changerequest.internal.DefaultChangeRequestManager.rebase(DefaultChangeRequestManager.java:335)
      	at org.xwiki.contrib.changerequest.internal.handlers.RebaseChangeRequestHandler.handleRebase(RebaseChangeRequestHandler.java:94)
      	at org.xwiki.contrib.changerequest.internal.handlers.RebaseChangeRequestHandler.handle(RebaseChangeRequestHandler.java:79)
      	at org.xwiki.contrib.changerequest.internal.handlers.ChangeRequestResourceHandler.handle(ChangeRequestResourceHandler.java:139)
      	at org.xwiki.resource.internal.DefaultResourceReferenceHandlerChain.handleNext(DefaultResourceReferenceHandlerChain.java:79)
      	at org.xwiki.resource.internal.AbstractResourceReferenceHandlerManager.handle(AbstractResourceReferenceHandlerManager.java:82)
      	at org.xwiki.resource.servlet.ResourceReferenceHandlerServlet.handleResourceReference(ResourceReferenceHandlerServlet.java:160)
      	at org.xwiki.resource.servlet.ResourceReferenceHandlerServlet.service(ResourceReferenceHandlerServlet.java:90)
      

      When merging:

      2025-07-31 15:03:10,450 [qtp1356728614-74 - http://localhost:8080/xwiki/changerequest/xwiki/merge/CR1-052767ed-2447-454f-b304-e32e3baacb81] WARN  c.x.x.d.XWikiDocument          - Abusive modification of the cached document [xwiki:Main.WebHome()] 
      java.lang.IllegalStateException: Abusive modification of the cached document
      	at com.xpn.xwiki.doc.XWikiDocument.setMetaDataDirty(XWikiDocument.java:2460)
      	at com.xpn.xwiki.doc.XWikiDocument.setDate(XWikiDocument.java:2329)
      	at com.xpn.xwiki.store.XWikiHibernateStore.saveXWikiDoc(XWikiHibernateStore.java:639)
      	at com.xpn.xwiki.store.XWikiCacheStore.saveXWikiDoc(XWikiCacheStore.java:277)
      	at com.xpn.xwiki.store.XWikiCacheStore.saveXWikiDoc(XWikiCacheStore.java:239)
      	at com.xpn.xwiki.XWiki.saveDocument(XWiki.java:2113)
      	at org.xwiki.contrib.changerequest.internal.storage.DefaultFileChangeStorageManager.mergeEdition(DefaultFileChangeStorageManager.java:616)
      	at org.xwiki.contrib.changerequest.internal.storage.DefaultFileChangeStorageManager.merge(DefaultFileChangeStorageManager.java:379)
      	at org.xwiki.contrib.changerequest.internal.storage.DefaultChangeRequestStorageManager.merge(DefaultChangeRequestStorageManager.java:386)
      	at org.xwiki.contrib.changerequest.internal.handlers.MergeChangeRequestHandler.handle(MergeChangeRequestHandler.java:72)
      	at org.xwiki.contrib.changerequest.internal.handlers.ChangeRequestResourceHandler.handle(ChangeRequestResourceHandler.java:139)
      

      Attachments

        Activity

          People

            surli Simon Urli
            surli Simon Urli
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: