Details
-
Bug
-
Resolution: Solved By
-
Major
-
None
-
0.7
-
None
-
Unknown
-
N/A
-
N/A
-
Description
Running the pnpm run --filter electron mac step of the release plan (e.g., https://cristal.xwiki.org/xwiki/bin/view/Release/Release07) fails.
A first error can be fix by installing dmg-license on the dev dependencies of @cristal/electron
But, even a second issue persist and needs to be fixed if we want to publish an max build for electron:
$ pnpm run --filter electron mac > @cristal/electron@0.7.0 mac /tmp/cristal/electron > electron-builder --mac dmg --config .electron-builder.config.js --dir --config.asar=false • electron-builder version=24.13.3 os=6.5.0-1020-oem • loaded configuration file=/tmp/cristal/electron/.electron-builder.config.js • description is missed in the package.json appPackageFile=/tmp/cristal/electron/package.json • writing effective config file=dist/builder-effective-config.yaml ⨯ /tmp/cristal/node_modules/iconv-corefoundation/lib/native.node: invalid ELF header failedTask=build stackTrace=Error: /tmp/cristal/node_modules/iconv-corefoundation/lib/native.node: invalid ELF header at Object.Module._extensions..node (node:internal/modules/cjs/loader:1465:18) at Module.load (node:internal/modules/cjs/loader:1206:32) at Function.Module._load (node:internal/modules/cjs/loader:1022:12) at Module.require (node:internal/modules/cjs/loader:1231:19) at require (node:internal/modules/helpers:179:18) at Object.<anonymous> (/tmp/cristal/node_modules/iconv-corefoundation/lib/native.js:5:18) at Module._compile (node:internal/modules/cjs/loader:1369:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1427:10) at Module.load (node:internal/modules/cjs/loader:1206:32) at Function.Module._load (node:internal/modules/cjs/loader:1022:12) at Module.require (node:internal/modules/cjs/loader:1231:19) at require (node:internal/modules/helpers:179:18) at Object.<anonymous> (/tmp/cristal/node_modules/iconv-corefoundation/lib/index.js:6:18) at Module._compile (node:internal/modules/cjs/loader:1369:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1427:10) at Module.load (node:internal/modules/cjs/loader:1206:32) /tmp/cristal/electron: ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL @cristal/electron@0.7.0 mac: `electron-builder --mac dmg --config .electron-builder.config.js --dir --config.asar=false` Exit status 1
We could also see how to build a single portable artifact with appimage for instance.
Attachments
Issue Links
- relates to
-
CRISTAL-311 Improve Cristal distributions
- Open