Uploaded image for project: 'Cristal'
  1. Cristal
  2. CRISTAL-624

Internal images are badly rendered on view with github

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • 0.15
    • Backend - Github
    • None
    • Unknown

    Description

      Reproduction steps

      1. edit a page on a GitHub backend
      2. insert a new image by uploading it
      3. observe that the image is displayed
      4. save and view the page
      5. observe that the image is displayed

      Expected

      The image is displayed in steps 3 and 5.

      Actual

      The image is only displayed in step 3, and not in step 5.

      The image is also not displayed if editing again the page.

      This is because, when uploading, the uploading endpoints returns the public url of the image, in the form https://raw.githubusercontent.com/USER/REPO/BRANCH/PATH?token=SOMETOKEN

      But on save, something like ![[ATTACHMENT_REFERENCE]] is persisted, which is converted back to an url.

      1. this convertion method is not producing the right url
      2. the url must contain the token

      Attachments

        Activity

          People

            Unassigned Unassigned
            mleduc Manuel Leduc
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated: