Uploaded image for project: 'Kubernetes Helm Charts for XWiki'
  1. Kubernetes Helm Charts for XWiki
  2. HELM-127

Hardcoded image for curl in solr initContainer

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • 1.7.3
    • None
    • Unknown

    Description

      Hi, I am setting up XWiki in an Openshift environment with internet restrictions, pulling images through our internal registry.

      In templates/solr-statefulset.yaml, the download-cores init container uses a hardcoded image:

          spec:
            {{- if .Values.solr.downloadCores.enabled }}
            initContainers:
              - name: download-cores
                image: curlimages/curl
                env:
                {{- range .Values.solr.extraEnvVars }}
                  - name: {{ .name  }}
                    value: {{ .value | quote }}
                {{- end }}
                command: ['/bin/sh', '-c']

      This hard coding of curlimages/curl will directly reference to docker.io.

      Perhaps this would be a better solution in templates/solr-statefulset.yaml

              - name: download-cores
                image: {{ .Values.solr.downloadCores.image | quote }}

      defaulting with:

      solr:
        downloadCores:
          enabled: true
          image: "curlimages/curl:latest" 

      It would also be an improvement for on premise installations with internet restrictions to allow the 2 variables: SOLR_CORE_URL and SOLR_MINIMAL_CORE_URL be configurable via values

      Thanks!

      Attachments

        Activity

          People

            Unassigned Unassigned
            Feathers Mcgraw Feathers Mcgraw
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated: