Uploaded image for project: 'Kubernetes Helm Charts for XWiki'
  1. Kubernetes Helm Charts for XWiki
  2. HELM-43

Systematically escape JVM properties

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 1.2.0, 1.1.3
    • 1.1.0, 1.2.0
    • None
    • Unknown

    Description

      We can have issues with JVM properties not being properly escaped, so it would be interesting to update https://github.com/xwiki-contrib/xwiki-helm/blob/052a047b946a9586845bd6a000f4dd0334c15859/charts/xwiki/templates/initialization-configmaps.yaml#L82C11-L82C11 so that the property value we are defining is escaped by default with double quotes, something along these lines :

          {{- range $file, $value := .Values.properties }}
            echo "-D{{ $file }}=\"{{ $value }}\"" >> /tmp/java_opts.txt
          {{- end }}
      

      Note that we will also need to escape any " that is present within $value.

      As the echo itself is also using some double quotes before the line to be added to java_opts, it may cause some issues too.

      Attachments

        Activity

          People

            sautner Guilherme Sautner
            caubin Clément Aubin
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: