Uploaded image for project: 'IRC Bot Application'
  1. IRC Bot Application
  2. IRCBOT-13

Nicer message on IRC channel when a mandatory class is saved

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 8.2
    • Fix Version/s: 8.2.1
    • Labels:
      None
    • Similar issues:

      Description

      Right now we get:

      commons:XWiki.XWikiComments was created by Guest - Failed to compute URL for document [commons:XWiki.XWikiComments] and query string [null]
      commons:XWiki.XWikiComments was modified by Guest - Failed to compute URL for document [commons:XWiki.XWikiComments] and query string [viewer=changes&rev2=2.1]
      

      And in the logs we have:

      2016-10-03 16:01:56,721 [http://test.xwiki.org/xwiki/bin/view/TestReportingExecutions/Oldcore+Tests.Export+Rtf6?xpage=print] WARN  .DocumentModifiedEventListener - Failed to compute URL for document [test:XWiki.XWikiComments] and query string [viewer=changes&rev2=2.1]
      java.lang.NullPointerException: null
              at com.xpn.xwiki.doc.XWikiDocument.getExternalURL(XWikiDocument.java:1994)
              at org.xwiki.ircbot.internal.DocumentModifiedEventListener.getNotificationURL(DocumentModifiedEventListener.java:262)
              at org.xwiki.ircbot.internal.DocumentModifiedEventListener.onEvent(DocumentModifiedEventListener.java:133)
              at org.xwiki.observation.internal.DefaultObservationManager.notify(DefaultObservationManager.java:304)
              at org.xwiki.observation.internal.DefaultObservationManager.notify(DefaultObservationManager.java:269)
              at com.xpn.xwiki.XWiki.saveDocument(XWiki.java:1695)
              at com.xpn.xwiki.XWiki.saveDocument(XWiki.java:1604)
              at com.xpn.xwiki.XWiki.saveDocument(XWiki.java:1596)
              at com.xpn.xwiki.XWiki.initializeMandatoryDocument(XWiki.java:1186)
              at com.xpn.xwiki.XWiki.initializeMandatoryDocuments(XWiki.java:1157)
              at com.xpn.xwiki.XWiki.updateDatabase(XWiki.java:1260)
              at com.xpn.xwiki.XWiki.updateDatabase(XWiki.java:1234)
              at com.xpn.xwiki.XWiki.getXWiki(XWiki.java:810)
              at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:238)
              at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:193)
              at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:425)
              at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:228)
              at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1913)
              at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:449)
              at javax.servlet.http.HttpServlet.service(HttpServlet.java:624)
      

        Attachments

          Activity

            People

            • Assignee:
              vmassol Vincent Massol
              Reporter:
              vmassol Vincent Massol
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: