Details
-
Improvement
-
Resolution: Unresolved
-
Major
-
None
-
2.2.1
-
None
-
Unknown
-
Description
The JW Player macro takes its width and height in plain text fields of the Edit Macro dialog, so any text can be typed and the player keeps its default size with no message.
The main problem:
- Both are numbers of pixels declared as strings: they need an integer type and a minimum of 1.
Depends on
Most of these fields cannot be offered before these generic changes, each giving the macro the means to declare the expected value:
- XWIKI-25182, which gives a number input to the parameters of a numeric type.
- XWIKI-25197, which lets a wiki macro parameter declare its minimum and maximum.
KOs covered
| Macro | Criterion | Parameter | Problem | Depends on |
|---|---|---|---|---|
| jwplayer | C4 input-assistance | width | A plain text field for a number of pixels: width="abc", width="-3" and width="0" are accepted and the player keeps its default size. | XWIKI-25182, XWIKI-25197 |
| jwplayer | C4 input-assistance | height | A plain text field for a number of pixels: height="abc", height="-3" and height="0" are accepted and the player keeps its default size. | XWIKI-25182, XWIKI-25197 |
Impact found on macro fluidity
These 2 KOs come from the WYSIWYG usability audit of the macros, under the criterion C4 input-assistance of its usability criteria. The page of each macro, linked in the table, has the full notes and the steps to reproduce. Fixing them means changing the declaration of the parameters in the macro definitions.
Attachments
Issue Links
- depends on
-
-
- Open
-
-
-
- Open
-