Uploaded image for project: 'Security Advisory Application'
  1. Security Advisory Application
  2. SPAPP-43

GitHub users registered by the advisory import are hidden from the "GitHub users mapping" administration table

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 2.3.1
    • 2.3.0
    • None
    • Unit
    • Unknown
    • N/A

    Description

      The "GitHub users mapping" table of the Security Advisory administration ("Administer Wiki" > "Other" > "Security Advisory") is empty by default, even when imported advisories involve GitHub users. An administrator therefore never sees the GitHub users to map or ignore, unless they clear the "Ignored" filter by hand.

      Steps to reproduce

      1. Import advisories from GitHub, so that some GitHub users are registered (one hidden page per user under SecurityAdvisoryApplication.Code.ExternalUsers).
      2. Open "Administer Wiki" > "Other" > "Security Advisory" and look at the "GitHub users mapping" table.

      Expected: the GitHub users that are not ignored are listed.
      Actual: "Entries 0 - 0 out of 0". Clearing the "Ignored" filter lists all of them, with an empty "Ignored" value.

      Cause

      The Live Data is declared with filters="archived=0", but ExternalUserMappingStore#register (and save in general) only sets hint, externalId and login on the ExternalUserMappingClass object: archived is never set, so it has no stored value and the filter excludes it. Only a user ignored then un-ignored gets archived=0.

      Either set archived to 0 when registering the external user (and migrate the existing pages), or make the filter match an empty value too.

      Introduced by SPAPP-25.

      Attachments

        Issue Links

          Activity

            People

              surli Simon Urli
              surli Simon Urli
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: