Uploaded image for project: 'URL Normalizer'
  1. URL Normalizer
  2. URLNORMALZ-23

Support all macro having wiki markup as their content

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 1.5
    • 1.4
    • None
    • None
    • Unit
    • Unknown

    Description

      Right now, we support a hardcoded subset of macros known to contain wiki markup, see: https://github.com/xwiki-contrib/application-urlnormalizer/blob/d322f12d8960e2271b45afcd5d90ce8da3dec05b/listener-urlnormalizer-api/src/main/java/org/xwiki/contrib/urlnormalizer/internal/MarkupContainingMacroBlockMatcher.java#L37

      XWiki 10.10RC1 has introduced the ability for macros to express that their content is wiki markup. Thus the code should be refactored to support this and thus support all well-developed macros (that correctly express their content type).

      For example, this would allow the Paragraph Numbering macro to be supported OOB.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-19822 Wrong content type for the Cache macro

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-19824 Wrong content type for the Context macro

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-19827 Wrong content type for the Container macro

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-19834 Wrong content type for the Chart macro

          • Major - Major loss of function.
          • Closed

          Activity

            [URLNORMALZ-23] Support all macro having wiki markup as their content
            vmassol Vincent Massol added a comment -

            When implementing, make sure to check for a List type having a class being an instanceof Block (i.e. Block or extending Block), so that we can handle specific cases such as the ContainerMacro which contains wiki markup but a restricted format of wiki markup and for which we may want, one day, to have a List<ContainerBlock> for ex, so that we can have a custom in-place editor for it.

            vmassol Vincent Massol added a comment - When implementing, make sure to check for a List type having a class being an instanceof Block (i.e. Block or extending Block), so that we can handle specific cases such as the ContainerMacro which contains wiki markup but a restricted format of wiki markup and for which we may want, one day, to have a List<ContainerBlock> for ex, so that we can have a custom in-place editor for it.

            People

              tmortagne Thomas Mortagne
              vmassol Vincent Massol
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: