Uploaded image for project: 'Reader Application'
  1. Reader Application
  2. XAREADER-5

The flag queries compare a long property with a string

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • 1.0-rc-2
    • None
    • Unknown

    Description

      ReaderCode.DefaultPressReviewFormatter and ReaderCode.ReaderArticlesMacro compare the key long property of the flags with a string:

      fkey.value = '$flag'
      

      Since Hibernate 6, HQL checks the types of both sides of a comparison when the query is parsed, and rejects incompatible ones (SemanticException: Cannot compare left expression of type ... with right expression of type ...). XWiki is moving to Hibernate 7 (XWIKI-19708), where these queries will fail on every database. With Hibernate 5 the literal is copied as is in the SQL, so the queries rely on the database converting it implicitly, which not all databases do.

      Bind the flag as a Long query parameter instead (which also avoids injecting it in the query). This works with all the databases and all the Hibernate versions.

      PS: This post was co-written with Claude Code.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              tmortagne Thomas Mortagne
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated: