Uploaded image for project: 'Publication Workflow Application'
  1. Publication Workflow Application
  2. XAWORKFLOW-111

Empty rigths objects added when no groups selected for viewer and/or commenter

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • 2.4.2
    • 2.3.2
    • None
    • Unknown

    Description

      Reproduction

      1. Create a new workflow and set
        1. Contributors group
        2. Moderators group
        3. Publishers group
        4. leave Viewers group empty
        5. leave Commenters group empty
        6. leave "Skip draft rights update on workflow transition" to No
      2. Create a new page. Set it to be a terminal page. Save it.
      3. Start the workflow on this page (you'll have to display the Workflow Panel first, to be able to click the "Start workflow" button)
      4. Open the page's objects and see:
        1. one XWikiRights object for the groups set for Contributors, Moderators, Publishers
        2. one XWikiRights object with no group set, for granting view rights (corresponding to the Viewers group)
        3. one XWikiRights object with no group set, for granting comment rights (corresponding to the Commenters group)

      Note: if not a terminal page, rights will be handled by the WebPreferences page, thus not having the issue

      Expectations

      There should be no empty XWikiRights objects set

       

      The code which sets the rules without checking if a group is set in the workflow is DefaultPublicationWorkflow.java

      Attachments

        Activity

          People

            acotiuga Alex Cotiugă
            mpace Mathieu Pace
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: