Uploaded image for project: 'XWiki Commons'
  1. XWiki Commons
  2. XCOMMONS-1290

Speed up EmbeddableComponentManager#getInstanceList

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 9.9
    • Fix Version/s: 9.10-rc-1
    • Component/s: Component
    • Labels:
    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Documentation in Release Notes:
      N/A
    • Similar issues:

      Description

      Right now getInstanceList go trough all component and select the ones with the right role type. It would help a lot to store components as a Map instead of a list in EmbeddableComponentManager with the role type as key.

      It would also avoid create a new RoleHint instance with each call of getInstance which will reduce pressure on garbage collector.

        Attachments

          Activity

            People

            • Assignee:
              tmortagne Thomas Mortagne
              Reporter:
              tmortagne Thomas Mortagne
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: