Uploaded image for project: '{RETIRED} XWiki Colibri Skin'
  1. {RETIRED} XWiki Colibri Skin
  2. XSCOLIBRI-123

#mainContentArea should have it's own padding-top value rather than depending on #hierarchy's padding-top value

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 1.4
    • 1.3
    • Skin
    • None

    Description

      This is how #mainContentArea styling looks like: (colibri.css: line 3437)

      #mainContentArea {
        background:#FFFFFF none repeat scroll 0 0;
        padding:0 25px 5px;
      }
      

      As you can see this styling does not define a padding-top value (it's set to 0). Now if you look at #hierarchy styling:

      #hierarchy {
        font-size:90%;
        padding-top:25px;
      }
      

      Since breadcrumbs (#hierarchy) is the first thing that occurs inside #mainContentArea, the rendered output looks pretty ok with this layout. However, this causes problems with pages that doesn't contain breadcrumbs like Admin UIs.

      I think it would be more appropriate if we move the "padding-top:25px;" from #hierarchy to #mainContentArea. This will fix the problem with admin UIs and it sounds more logical too.

      Attachments

        Activity

          People

            sdumitriu Sergiu Dumitriu
            asiri Asiri Rathnayake
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: