Uploaded image for project: 'Guided Tour'
  1. Guided Tour
  2. GUIDEDTOUR-28

The Guided Tour scripts are loaded and the tours are fetched on every page, even when no tour is active

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • 0.1
    • None
    • Unknown

    Description

      The Guided Tour UI extension adds the guidedtour-webjar script to every page through org.xwiki.platform.template.header.after, and the widget then fetches the tours and their tasks over REST, whether or not any tour is active.

      Steps to reproduce

      1. Install Guided Tour 0.1 with the default tours
      2. Edit every tour under GuidedTour.Tours and set "Is active" to "No"
      3. Open any page with the browser network tab open

      Expected

      No Guided Tour script or REST request is loaded, and no widget is displayed.

      Actual

      The following requests are made on every page:

      • /webjars/wiki%3Axwiki/guidedtour-webjar/0.1/index.es.js
      • /webjars/wiki%3Axwiki/guidedtour-node-ui/0.1/index.es.js
      • /rest/guidedTour/tours
      • /rest/guidedTour/tours/<tour>/tasks, once per tour, including the inactive ones

      An empty "Guided Tours" widget is also displayed in the bottom-right corner.

      This is the same problem as XWIKI-21823 on the Tour application.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Lucas C Charpentier Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: